1349895 - Support HTC Vive trackers

Status: RESOLVED FIXED

(Core :: WebVR, enhancement)

Description

[Daosheng Mu[:daoshengmu]]

HTC Vive trackers are TrackedDeviceClass_GenericTracker not TrackedDeviceClass_Controller devices. Therefore, we can't support them directly via our existing OpenVR controllers work.

Comment 1

[Daosheng Mu[:daoshengmu]]

Attachment: Bug 1349895 - Vive Tracker support in OpenVR;

Review commit: https://reviewboard.mozilla.org/r/123084/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/123084/

Comment 2

[Daosheng Mu[:daoshengmu]]

Comment on attachment 8850486 [details]
Bug 1349895 - Vive Tracker support in OpenVR;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/123084/diff/1-2/

Comment 3

[Daosheng Mu[:daoshengmu]]

According to Vive Tracker SDK, https://dl.vive.com/Tracker/Guideline/HTC_Vive_Tracker_Developer_Guidelines_v1.3.pdf page 7, it allows developers to define its button input.

However, Vive Tracker has problems on detecting the number of buttons and axes on its property. I have tried it at openvr sample code, I still got the same result. It always has the same number as Vive Controller. I have filed a topic at Vive forum to look forward the answer, http://community.viveport.com/t5/General-Vive-Discussion/Button-and-Axis-count-on-Vive-Tracker/m-p/6748#U6748.

My expectation is Tracker should have zero button and axis. It only has pose info if it does not dock to any real device.

Comment 4

[Daosheng Mu[:daoshengmu]]

Comment on attachment 8850486 [details]
Bug 1349895 - Vive Tracker support in OpenVR;

Cancel the review because I have some ideas wanna continue to try.

Comment 5

[Daosheng Mu[:daoshengmu]]

Comment on attachment 8850486 [details]
Bug 1349895 - Vive Tracker support in OpenVR;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/123084/diff/2-3/

Comment 6

[Daosheng Mu[:daoshengmu]]

According to https://dl.vive.com/Tracker/Guideline/HTC_Vive_Tracker_Developer_Guidelines_v1.3.pdf p. 7 and p. 20. It looks like Tracker has already defined the button and axis mapping and just let other accessories to emit these digital input and output events to Tracker. Therefore, the button and axis of Tracker have unified count as Vive Controller.

Comment 7

[:kip (Kearwood Gilbert)]

Comment on attachment 8850486 [details]
Bug 1349895 - Vive Tracker support in OpenVR;

https://reviewboard.mozilla.org/r/123084/#review130484

Looks good!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3bae8c02fe0c
Vive Tracker support in OpenVR; r=kip

Comment 9

[:kip (Kearwood Gilbert)]

(In reply to Daosheng Mu[:daoshengmu] from comment #6)
> According to
> https://dl.vive.com/Tracker/Guideline/
> HTC_Vive_Tracker_Developer_Guidelines_v1.3.pdf p. 7 and p. 20. It looks like
> Tracker has already defined the button and axis mapping and just let other
> accessories to emit these digital input and output events to Tracker.
> Therefore, the button and axis of Tracker have unified count as Vive
> Controller.

Accoding to the pogo-pin pinouts of the Vive tracker, they essentially always have 4 buttons even if no additional device is attached to its USB port.  The device itself is unable to determine at an electrical level if a switch for the buttons is connected.

I don't think this should cause any issues; however, as applications using the Vive trackers should probably be expecting specific peripherals connected to them or ask the user to bind the buttons on the trackers if they will be used for more than poses.

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/3bae8c02fe0c