1350030 - Move `serverForEngine` into common test helpers

Status: RESOLVED FIXED

(Firefox :: Sync, enhancement, P1)

Description

[Lina Butler (ex-Mozilla)]

Bug 1349709 added a `serverForEngine` function that creates a server with existing fake encryption keys, and a collection for an engine. This is useful for avoiding an initial full sync to upload keys.

There are several other tests that have similar functions. Let's move it into http://searchfox.org/mozilla-central/rev/9af9b1c7946ebef6056d2ee4c368d496395cf1c8/services/sync/tests/unit/head_http_server.js, and convert the tests to use the common one.

Comment 1

[Lina Butler (ex-Mozilla)]

I'd like this for testing bug 1335891, so snagging.

Comment 2

[Lina Butler (ex-Mozilla)]

Attachment: Bug 1350030 - Extract `serverForEngine` into `serverForEnginesWithKeys`.

Review commit: https://reviewboard.mozilla.org/r/125280/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/125280/

Comment 3

[Lina Butler (ex-Mozilla)]

Comment on attachment 8853201 [details]
Bug 1350030 - Extract `serverForEngine` into `serverForEnginesWithKeys`.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/125280/diff/1-2/

Comment 4

[Thom Chiovoloni [:tcsc] (ex-moco)]

Comment on attachment 8853201 [details]
Bug 1350030 - Extract `serverForEngine` into `serverForEnginesWithKeys`.

https://reviewboard.mozilla.org/r/125280/#review138130

This is great! No more copy/pasting this function around.

Comment 5

[Lina Butler (ex-Mozilla)]

Comment on attachment 8853201 [details]
Bug 1350030 - Extract `serverForEngine` into `serverForEnginesWithKeys`.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/125280/diff/2-3/

Comment 6

[Lina Butler (ex-Mozilla)]

Comment on attachment 8853201 [details]
Bug 1350030 - Extract `serverForEngine` into `serverForEnginesWithKeys`.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/125280/diff/3-4/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0db9bc0e90a8
Extract `serverForEngine` into `serverForEnginesWithKeys`. r=tcsc

Comment 8

[Iris Hsiao [:ihsiao]]

https://hg.mozilla.org/mozilla-central/rev/0db9bc0e90a8