Closed Bug 1350030 Opened 3 years ago Closed 3 years ago

Move `serverForEngine` into common test helpers

Categories

(Firefox :: Sync, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 55
Tracking Status
firefox55 --- fixed

People

(Reporter: Lina, Assigned: Lina)

Details

Attachments

(1 file)

Bug 1349709 added a `serverForEngine` function that creates a server with existing fake encryption keys, and a collection for an engine. This is useful for avoiding an initial full sync to upload keys.

There are several other tests that have similar functions. Let's move it into http://searchfox.org/mozilla-central/rev/9af9b1c7946ebef6056d2ee4c368d496395cf1c8/services/sync/tests/unit/head_http_server.js, and convert the tests to use the common one.
Mentor: kit
Keywords: good-first-bug
Mentor: kit
Keywords: good-first-bug
Priority: -- → P1
I'd like this for testing bug 1335891, so snagging.
Assignee: nobody → kit
Status: NEW → ASSIGNED
Comment on attachment 8853201 [details]
Bug 1350030 - Extract `serverForEngine` into `serverForEnginesWithKeys`.

https://reviewboard.mozilla.org/r/125280/#review138130

This is great! No more copy/pasting this function around.
Attachment #8853201 - Flags: review?(tchiovoloni) → review+
Pushed by kcambridge@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0db9bc0e90a8
Extract `serverForEngine` into `serverForEnginesWithKeys`. r=tcsc
https://hg.mozilla.org/mozilla-central/rev/0db9bc0e90a8
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
You need to log in before you can comment on or make changes to this bug.