1350055 - --disable-webrtc build fails with "netwerk/ipc/PNecko.ipdl:27: error: can't locate include file `PStunAddrsRequest.ipdl'"

Status: RESOLVED FIXED

(Core :: WebRTC, defect, P1)

Description

[Mats Palmgren (inactive)]

STEPS TO REPRODUCE
1. add "ac_add_options --disable-webrtc" to your .mozconfig file
2. rebuild with an empty $OBJDIR

ACTUAL RESULTS
[...]
 0:33.29 shistory.xpt
 0:33.30   in file included from `/md1/src/inbound/accessible/ipc/other/PDocAccessible.ipdl', line 7:
 0:33.30   in file included from `/md1/src/inbound/ipc/glue/PFileDescriptorSet.ipdl', line 5:
 0:33.30   in file included from `/md1/src/inbound/ipc/glue/PBackground.ipdl', line 6:
 0:33.30   in file included from `/md1/src/inbound/dom/indexedDB/PBackgroundIDBFactory.ipdl', line 6:
 0:33.30   in file included from `/md1/src/inbound/dom/indexedDB/PBackgroundIDBDatabase.ipdl', line 6:
 0:33.30   in file included from `/md1/src/inbound/dom/indexedDB/PBackgroundIDBDatabaseRequest.ipdl', line 6:
 0:33.30   in file included from `/md1/src/inbound/dom/filehandle/PBackgroundMutableFile.ipdl', line 5:
 0:33.30   in file included from `/md1/src/inbound/dom/filehandle/PBackgroundFileHandle.ipdl', line 5:
 0:33.30   in file included from `/md1/src/inbound/dom/filehandle/PBackgroundFileRequest.ipdl', line 6:
 0:33.30   in file included from `/md1/src/inbound/dom/file/ipc/PBlob.ipdl', line 7:
 0:33.30   in file included from `/md1/src/inbound/dom/ipc/PContent.ipdl', line 14:
 0:33.30   in file included from `/md1/src/inbound/security/manager/ssl/PPSMContentDownloader.ipdl', line 7:
 0:33.30   in file included from `/md1/src/inbound/netwerk/ipc/PChannelDiverter.ipdl', line 7:
 0:33.30   in file included from `/md1/src/inbound/netwerk/protocol/ftp/PFTPChannel.ipdl', line 8:
 0:33.30 /md1/src/inbound/netwerk/ipc/PNecko.ipdl:27: error: can't locate include file `PStunAddrsRequest.ipdl'
 0:33.30 Specification could not be parsed.
 0:33.32 warning: [const] doesn't make sense on builtin types., <class 'xpidl.xpidl.BuiltinLocation'>
 0:33.32 warning: [const] doesn't make sense on builtin types., <class 'xpidl.xpidl.BuiltinLocation'>
 0:33.32 warning: [const] doesn't make sense on builtin types., <class 'xpidl.xpidl.BuiltinLocation'>
 0:33.32 warning: [const] doesn't make sense on builtin types., <class 'xpidl.xpidl.BuiltinLocation'>
 0:33.32 warning: [const] doesn't make sense on builtin types., <class 'xpidl.xpidl.BuiltinLocation'>
 0:33.32 warning: [const] doesn't make sense on builtin types., <class 'xpidl.xpidl.BuiltinLocation'>
 0:33.32 warning: [const] doesn't make sense on builtin types., <class 'xpidl.xpidl.BuiltinLocation'>
 0:33.32 warning: [const] doesn't make sense on builtin types., <class 'xpidl.xpidl.BuiltinLocation'>
 0:33.32 warning: [const] doesn't make sense on builtin types., <class 'xpidl.xpidl.BuiltinLocation'>
 0:33.32 warning: [const] doesn't make sense on builtin types., <class 'xpidl.xpidl.BuiltinLocation'>
 0:33.32 warning: [const] doesn't make sense on builtin types., <class 'xpidl.xpidl.BuiltinLocation'>
 0:33.32 warning: [const] doesn't make sense on builtin types., <class 'xpidl.xpidl.BuiltinLocation'>
 0:33.35 startupcache.xpt
[...]

Comment 1

[Mats Palmgren (inactive)]

The PStunAddrsRequest.ipdl file was added in bug 1345511 so I'm guessing
it's a regression from that bug.

Comment 2

[Michael Froman [:mjf]]

Attachment: Bug 1350055 - fix --disable-webrtc build with new PStunAddrsRequest.ipdl

Review commit: https://reviewboard.mozilla.org/r/123348/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/123348/

Comment 3

[Michael Froman [:mjf]]

(In reply to Mats Palmgren (:mats) from comment #1)
> The PStunAddrsRequest.ipdl file was added in bug 1345511 so I'm guessing
> it's a regression from that bug.

Mats, if you could double check that this patch fixes the --disable-webrtc build for you it would be much appreciated.  It builds here on my linux machine now, but I'd love a double check.

Comment 4

[Mats Palmgren (inactive)]

With that patch applied I now get errors when linking libxul.so:
10:28.00 ../../build/unix/gold/ld: error: read-only segment has dynamic relocations
10:28.00 /md1/objdir/md1/src/inbound/dist/include/nsTArray.h:559: error: undefined reference to 'mozilla::NrIceStunAddr::~NrIceStunAddr()'
10:28.00 /md1/objdir/md1/src/inbound/dist/include/nsTArray.h:545: error: undefined reference to 'mozilla::NrIceStunAddr::NrIceStunAddr()'
10:28.00 /md1/objdir/md1/src/inbound/dist/include/mozilla/net/NrIceStunAddrMessageUtils.h:29: error: undefined reference to 'mozilla::NrIceStunAddr::SerializationBufferSize() const'
10:28.00 /md1/objdir/md1/src/inbound/dist/include/mozilla/net/NrIceStunAddrMessageUtils.h:36: error: undefined reference to 'mozilla::NrIceStunAddr::Deserialize(char const*, unsigned long)'
10:28.00 /md1/objdir/md1/src/inbound/dist/include/mozilla/net/NrIceStunAddrMessageUtils.h:18: error: undefined reference to 'mozilla::NrIceStunAddr::SerializationBufferSize() const'
10:28.00 /md1/objdir/md1/src/inbound/dist/include/mozilla/net/NrIceStunAddrMessageUtils.h:20: error: undefined reference to 'mozilla::NrIceStunAddr::Serialize(char*, unsigned long) const'
10:28.00 clang: error: linker command failed with exit code 1 (use -v to see invocation)

Comment 5

[Mats Palmgren (inactive)]

BTW, my .mozconfig has:
ac_add_options --enable-debug
ac_add_options --disable-optimize
ac_add_options --disable-webrtc
ac_add_options --disable-eme
ac_add_options --disable-accessibility
ac_add_options --disable-crashreporter
ac_add_options --disable-necko-wifi

Can you reproduce with those settings?

Comment 6

[Michael Froman [:mjf]]

Not with _only_ those changes. :-)  In your log I noticed a clang error and changed my .mozconfig to use clang and I can replicate your failure.

Comment 7

[Michael Froman [:mjf]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d1c2ccf4b2c6

Comment 8

[Michael Froman [:mjf]]

Comment on attachment 8850834 [details]
Bug 1350055 - fix --disable-webrtc build with new PStunAddrsRequest.ipdl

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/123348/diff/1-2/

Comment 9

[Mozilla Autoland]

hg error in cmd: hg identify upstream -r tip:

Comment 10

[Michael Froman [:mjf]]

Mats, could you give this one more try?  It is building with clang and your .mozconfig options on my end.

Comment 11

[Mats Palmgren (inactive)]

The latest patch works fine for me, thanks!

Comment 12

[Jason Duell]

Comment on attachment 8850834 [details]
Bug 1350055 - fix --disable-webrtc build with new PStunAddrsRequest.ipdl

https://reviewboard.mozilla.org/r/123348/#review126472

Looks good to me

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3b7cbfca077a
fix --disable-webrtc build with new PStunAddrsRequest.ipdl r=jduell

Comment 14

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3b7cbfca077a