urlbarBindings.xml should use AppConstants from the global scope

RESOLVED FIXED in Firefox 55

Status

()

enhancement
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: dao, Assigned: fedepad, Mentored)

Tracking

({good-first-bug})

unspecified
Firefox 55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

(Whiteboard: [good first bug][lang=js])

Attachments

(1 attachment)

Reporter

Description

2 years ago
+++ This bug was initially created as a clone of Bug #1349502 +++

Instead of 'this.AppConstants', urlbarBindings.xml should use the global 'AppConstants', and we should remove this field:

http://searchfox.org/mozilla-central/rev/c48398abd9f0f074c69f2223260939e30e8f99a8/browser/base/content/urlbarBindings.xml#56-59
Comment hidden (mozreview-request)
Reporter

Comment 2

2 years ago
mozreview-review
Comment on attachment 8851256 [details]
Bug 1350063 - urlbarBindings.xml should use AppConstants from the global scope;

https://reviewboard.mozilla.org/r/123610/#review126098

Looks good. Thanks!
Attachment #8851256 - Flags: review?(dao+bmo) → review+
Reporter

Updated

2 years ago
Assignee: nobody → federico_padua

Comment 3

2 years ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/31235aad2d6a
urlbarBindings.xml should use AppConstants from the global scope; r=dao
Assignee

Comment 4

2 years ago
mozreview-review-reply
Comment on attachment 8851256 [details]
Bug 1350063 - urlbarBindings.xml should use AppConstants from the global scope;

https://reviewboard.mozilla.org/r/123610/#review126098

You're welcome! I cannot trigger try builds or any other stuff, so you should handle that ;)
Reporter

Comment 5

2 years ago
(In reply to Federico Padua (fedepad) from comment #4)
> You're welcome! I cannot trigger try builds or any other stuff, so you
> should handle that ;)

This seems simple enough that I just triggered landing on autoland right away.

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/31235aad2d6a
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
You need to log in before you can comment on or make changes to this bug.