135011 - Web Progress Listeners should be able to retrieve images security state

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Kai Engert (:KaiE:)]

When OnStateChange gets called, while data is loaded from the network, the
security code looks at the data transfered, and collects information, whether
objects are transfered securely or not.

It does this by QIing the given nsIRequest to nsIChannel, and extracting the
security state info.

This does not work for images. QIing thos nsIRequest objects to nsIChannel, that
are received for loaded images, does not succeed.

I don't know yet what class we are actually receiving, but peterv suspected it
might be imgRequestProxy.

Expected behaviour:

Requests given to OnStateChange as images are loaded, should be QIable to
nsIChannel.

Stuart suspected, it might be tricky to do that, because the used channel is
shared amongst multiple loaded images. Not sure if that's really a problem for
us, I can't judge. All we want to do is extract the security information from
the channel.

I saw that imgRequest contains a nsIChannel member. If you don't want to support
QIing imgRequestProxy to nsIChannel, I would like to request a way to retrieve
the imgRequestProxy's security state from the nsIChannel which it is using
internally, and make that publicly available.

Comment 1

[Kai Engert (:KaiE:)]

This block 135007.

Comment 2

[Kai Engert (:KaiE:)]

Nominating

Comment 3

[Samir Gehani]

adt: nsbeta1-

Comment 4

[Kai Engert (:KaiE:)]

-> me

Comment 5

[Vedran Miletic]

retargeting

Comment 6

[Doug Turner (:dougt)]

Attachment: bandaide/workaround

This is somewhat of a workaround.  this will allow you to get the network request via new interface:  imgIRequest_MOZILLA_1_8_BRANCH.

For the trunk, we might as well just add this new attribute to the imgIRequest.

Comment 7

[Doug Turner (:dougt)]

mass reassigning to nobody.

Comment 8

[Doug Turner (:dougt)]

Comment on attachment 245026 [details] [diff] [review]
bandaide/workaround

clearing review flag.

Comment 9

[Serge Gautherie (:sgautherie)]

Filter on "Nobody_NScomTLD_20080620"

Comment 10

[Kai Engert (:KaiE:)]

I think the requested change has been implemented as part of bug 135007, marking fixed.