Missing CryptoManager.verifyCertificateNowCUNative() implementation.

RESOLVED FIXED

Status

JSS
Library
RESOLVED FIXED
9 months ago
9 months ago

People

(Reporter: Endi S. Dewata, Assigned: Elio Maldonado)

Tracking

Details

Attachments

(1 attachment)

(Reporter)

Description

9 months ago
User Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:50.0) Gecko/20100101 Firefox/50.0
Build ID: 20161213225041

Steps to reproduce:

The verifyCertificateNowCUNative() is a native method used by several other methods in CryptoManager such as isCertValid().


Actual results:

Calling CryptoManager.isCertValid() results in the following exception:

java.lang.UnsatisfiedLinkError: org.mozilla.jss.CryptoManager.verifyCertificateNowCUNative(Ljava/lang/String;Z)I
        at org.mozilla.jss.CryptoManager.verifyCertificateNowCUNative(Native Method)
        at org.mozilla.jss.CryptoManager.isCertValid(CryptoManager.java:1568)



Expected results:

The missing native code should be restored and the CryptoManager.isCertValid() should work properly.
(Assignee)

Updated

9 months ago
Assignee: glenbeasley → emaldona
(Assignee)

Updated

9 months ago
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
(Assignee)

Comment 1

9 months ago
I confirmed this by looking at the code. verifyCertificateNowCUNative is listed on https://hg.mozilla.org/projects/jss/file/2cc681188411/lib/jss.def#l306 but no implementation is found in https://hg.mozilla.org/projects/jss/file/2cc681188411/org/mozilla/jss/PK11Finder.c. Neither can  verifyCertificateNow be found which is the function verifyCertificateNowCUNative calls as I saw in the older versions downstream code bore we did the merge. I'm the one who made the mistake of dropping those two when working on the merge of downstream patches. I patch that restore them is coming next.
(Assignee)

Comment 2

9 months ago
Created attachment 8851706 [details] [diff] [review]
provide verifyCertificateNowCUNative implementation
Attachment #8851706 - Flags: review?(edewata)
(Reporter)

Updated

9 months ago
Attachment #8851706 - Flags: review?(edewata) → review+
(Assignee)

Comment 3

9 months ago
Pushed: https://hg.mozilla.org/projects/jss/rev/b3e864205ff027dac3ef52847f74695e429a7f45
(Assignee)

Updated

9 months ago
Status: ASSIGNED → RESOLVED
Last Resolved: 9 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.