Closed Bug 1350182 Opened 3 years ago Closed 3 years ago

Enable button border display items by default

Categories

(Core :: Graphics: WebRender, enhancement)

51 Branch
enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: mchang, Assigned: mchang)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch Enable button box borders (obsolete) — Splinter Review
No description provided.
Attachment #8850798 - Flags: review?(ethlin)
Attachment #8850798 - Attachment is obsolete: true
Attachment #8850798 - Flags: review?(ethlin)
Attachment #8850799 - Flags: review?(ethlin)
Comment on attachment 8850799 [details] [diff] [review]
Enable button box borders

Review of attachment 8850799 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/forms/nsButtonFrameRenderer.cpp
@@ +184,5 @@
> +    if (!br) {
> +      return LAYER_NONE;
> +    }
> +
> +    mBorderRenderer = br;

I think you should check nsCSSBorderRenderer's CanCreateWebrenderCommands too, though the try result should be the same.
Attachment #8850799 - Flags: review?(ethlin) → review+
Comment on attachment 8850799 [details] [diff] [review]
Enable button box borders

Review of attachment 8850799 [details] [diff] [review]:
-----------------------------------------------------------------

::: modules/libpref/init/all.js
@@ +5646,4 @@
>  #ifdef MOZ_ENABLE_WEBRENDER
>  pref("layers.advanced.caret-layers", true);
>  pref("layers.advanced.boxshadow-outer-layers", false);
> +pref("layers.advanced.displaybuttonborder-layers", true);

Note that bug 1349949 is now on the graphics branch, so you'll need to rebase this. In all.js, set the pref value to 2, and in gfxPrefs.h, change the pref from a DECL_GFX_PREF to a DECL_OVERRIDE_PREF and use gfxPrefs::OverrideBase_WebRender() as the base value. See layers.advanced.caret-layers in that file for an example.
Pushed by mchang@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/a6f35285bd1e
Enable button border display items by default. r=ethlin
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Blocks: 1342343
You need to log in before you can comment on or make changes to this bug.