Closed
Bug 1350192
Opened 7 years ago
Closed 7 years ago
Permission panels blink when other pop-ups close
Categories
(Core :: XUL, defect)
Tracking
()
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox52 | --- | unaffected |
firefox-esr52 | --- | unaffected |
firefox53 | --- | unaffected |
firefox54 | --- | unaffected |
firefox55 | + | fixed |
People
(Reporter: 684sigma, Assigned: enndeakin)
References
Details
(Keywords: regression)
Attachments
(1 file)
3.20 KB,
patch
|
bytesized
:
review+
|
Details | Diff | Splinter Review |
I have a problem with Firefox Nightly 55. It doesn't happen in Beta 52, Beta 53. Sometimes when closing popups, permission panels blink. Here're 2 ways to reproduce it First: 1. Open https://www.w3schools.com/html/html5_geolocation.asp , click "Try it" button on the page to open permission panel 2. Click on menu button to open panel 3. Click outside menu button to close panel Second: 1. Open https://mozdevs.github.io/MediaRecorder-examples/record-video-and-audio.html , wait until permission panel opens 2. Click on magnifier glass icon in search bar to open suggestions 3. Click outside suggestions to close them Result: permission panel blinks Expected: shouldn't blink (should disappear like in ESR 45, or just not blink)
Has STR: --- → yes
Keywords: regression
Regression range: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=08ec5181293b12043a947b1905a949d60396485f&tochange=a57d843357e2d93d43e2508de1793f63b355fab9 Neil Deakin — Bug 1318705, combine the two lists of open popups in nsXULPopupManager into a single list to make iterating and managing them easier. Instead a noautohide flag is used to distinguish what used to be the difference between the lists, r=ksteuber
Blocks: 1318705
Status: UNCONFIRMED → NEW
Has Regression Range: --- → yes
status-firefox52:
--- → unaffected
status-firefox53:
--- → unaffected
status-firefox54:
--- → unaffected
status-firefox55:
--- → affected
tracking-firefox55:
--- → ?
Component: Untriaged → XP Toolkit/Widgets: Menus
Ever confirmed: true
Flags: needinfo?(enndeakin)
Product: Firefox → Core
Assignee | ||
Comment 2•7 years ago
|
||
Assignee: nobody → enndeakin
Status: NEW → ASSIGNED
Flags: needinfo?(enndeakin)
Assignee | ||
Comment 4•7 years ago
|
||
Comment on attachment 8852082 [details] [diff] [review] Skip noautohide popup in a couple of more places Followup to 1318705.
Attachment #8852082 -
Flags: review?(ksteuber)
Comment 5•7 years ago
|
||
Comment on attachment 8852082 [details] [diff] [review] Skip noautohide popup in a couple of more places Review of attachment 8852082 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me
Attachment #8852082 -
Flags: review?(ksteuber) → review+
Pushed by neil@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/55d087f91214 when checking through the list of popups to hide when clicking outside the popup, don't include noautohide popups, r=ksteuber
Comment 7•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/55d087f91214
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Updated•7 years ago
|
status-firefox-esr52:
--- → unaffected
Updated•5 years ago
|
Component: XP Toolkit/Widgets: Menus → XUL
You need to log in
before you can comment on or make changes to this bug.
Description
•