Specify text color of selected profile item instead of inheriting from global autocomplete style

RESOLVED FIXED in Firefox 55

Status

()

Toolkit
Form Manager
P3
normal
RESOLVED FIXED
5 months ago
a month ago

People

(Reporter: ralin, Assigned: ralin)

Tracking

53 Branch
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

(Whiteboard: [form autofill:M1])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

5 months ago
Need to explicitly set text color for selected item after Bug 1348574 landed.
Comment hidden (mozreview-request)
(Assignee)

Comment 2

5 months ago
Hi Matt,

Since this is a one line change patch, would you mind to have a quick look to the patch if you get time? Here I just simply fix the color of primary label. Thanks :D
Comment on attachment 8850853 [details]
Bug 1350208 - Explicitly set default text color for profile item.

https://reviewboard.mozilla.org/r/123374/#review127044
Attachment #8850853 - Flags: review?(MattN+bmo) → review+

Comment 4

5 months ago
Pushed by mozilla@noorenberghe.ca:
https://hg.mozilla.org/integration/autoland/rev/700fc0e95f64
Explicitly set default text color for profile item. r=MattN

Comment 5

5 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/700fc0e95f64
Status: ASSIGNED → RESOLVED
Last Resolved: 5 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Vance, could you please follow up on this bug as to the exact expected behavior is in regards to this bug?
Flags: needinfo?(vchen)
(Assignee)

Comment 7

a month ago
Steal the question from Vance :P

Since the dropdown is shared between multiple components, our stylesheets might be overwritten if we inherited the color from dropdown. In this bug, no new features or appearance change in this bug, instead we just explicitly set text color for our dropdown item in order to protect it from accidentally being broken by other components in the future. I'm afraid I couldn't give you the steps to verify this bug, perhaps, we can check whether the text color does conform with the spec or just ignore this bug. Thanks.
Flags: needinfo?(vchen)
You need to log in before you can comment on or make changes to this bug.