Support L10N properties loader in Launchpad

RESOLVED FIXED in Firefox 55

Status

()

Firefox
Developer Tools: Netmonitor
P1
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: gasolin@mozilla.com, Assigned: rickychien)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 55
Points:
---
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox55 fixed)

Details

(Whiteboard: [netmonitor])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

a year ago
We plan to run netmonitor on both toolbar and browser tab.

* Write a l10n properties loader
* Support L10N.numberWithDecimals
* Avoid plural-form.js, intl.properties, l10n.js duplication
(Reporter)

Updated

a year ago
Priority: -- → P1
Whiteboard: [netmonitor]
Flags: qe-verify?
Priority: P1 → P2
Flags: qe-verify? → qe-verify-
(Assignee)

Updated

a year ago
Assignee: nobody → rchien
Status: NEW → ASSIGNED
Support L10N.numberWithDecimals in devtools-core has done in https://github.com/devtools-html/devtools-core/pull/275.
Iteration: --- → 55.2 - Apr 3
Priority: P2 → P1
After having a discussion with Jason, we agreed that move http://searchfox.org/mozilla-central/source/devtools/shared/l10n.js to devtools-core/packages/devtools-module. PR is coming soon.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
L10N done! After fixing L10N issues, launchpad can be bootstrapped properly and see the landing page. Next step will fix connection timeout.

Comment 7

a year ago
mozreview-review
Comment on attachment 8852789 [details]
Bug 1350218 - Support L10N properties loader in Launchpad

https://reviewboard.mozilla.org/r/124962/#review127700

I have nothing to add, looks good to me.

R+

Thanks Ricky!

Honza
Attachment #8852789 - Flags: review?(odvarko) → review+

Comment 8

a year ago
Pushed by rchien@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0896cb720b91
Support L10N properties loader in Launchpad r=Honza

Comment 9

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/0896cb720b91
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
You need to log in before you can comment on or make changes to this bug.