Closed Bug 1350220 Opened 7 years ago Closed 7 years ago

Resolve Cyclic dependency between WebConsoleClient, LongStringClient in Firefox module system

Categories

(DevTools :: Netmonitor, enhancement, P1)

Product:
DevTools
Component:
Netmonitor
Type:
enhancement

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Iteration:
55.2 - Apr 3

People

(Reporter: gasolin, Assigned: rickychien)

References

Details

(Whiteboard: [netmonitor]) 

We plan to run netmonitor on both toolbar and browser tab.

TypeError: LongStringClient is not a constructor
WebConsoleClient requires a LongStringClient which is part of debuggerClient
debuggerClient requires WebConsoleClient
Priority: -- → P1
Whiteboard: [netmonitor]
Flags: qe-verify?
Priority: P1 → P2
Assignee: nobody → rchien
Status: NEW → ASSIGNED
Priority: P2 → P1
Iteration: --- → 55.2 - Apr 3
Flags: qe-verify? → qe-verify-
This issue has been fixed in devtools-core https://github.com/devtools-html/devtools-core/pull/274. Cyclic only happen in node module system but not in devtools loader.

Jason, do you think is it necessary to sync this changeset to m-c?
Flags: needinfo?(jlaster)
we are not prioritizing syncing the client work back, so it is not important at the moment.
Flags: needinfo?(jlaster)
Thanks.

This bug is used for tracking Github RP and patch has been landed in https://github.com/devtools-html/devtools-core/pull/274.

According comment 2, we agreed m-c synchronization is not important at the moment, let's close it.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.