Closed Bug 1350221 Opened 7 years ago Closed 7 years ago

Support for loading Chart in Launchpad

Categories

(DevTools :: Netmonitor, enhancement, P1)

Product:
DevTools
Component:
Netmonitor
Type:
enhancement

Tracking

(firefox55 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 55
Iteration:
55.3 - Apr 17
Tracking Flags:
Tracking Status
firefox55 --- fixed

People

(Reporter: gasolin, Assigned: rickychien)

References

Details

(Whiteboard: [netmonitor])

Attachments

(1 file)

Bug 1350221 - Support for loading Chart in Launchpad
59 bytes, text/x-review-board-request
Honza
: review+
Details 
We need new alias and move chart.js into devtools-modules
Flags: qe-verify?
Whiteboard: [netmonitor]
Priority: -- → P2
Flags: qe-verify? → qe-verify-
Assignee: nobody → gasolin
Status: NEW → ASSIGNED
Iteration: --- → 55.2 - Apr 3
Priority: P2 → P1
Iteration: 55.2 - Apr 3 → 55.3 - Apr 17
Assignee: gasolin → rchien
UI broken in chart view is just a one line patch to fix. Without importing widgets.css, the statistic panel will display improperly.
This patch needs to apply patches in bug 1352699.
Comment on attachment 8855723 [details]
Bug 1350221 - Support for loading Chart in Launchpad

https://reviewboard.mozilla.org/r/127616/#review130312

Tested on my machine and works just fine.

Thanks Ricky!

Honza
Attachment #8855723 - Flags: review?(odvarko) → review+
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 8e1561a21b44 -d 39a3c3fbfabd: rebasing 387981:8e1561a21b44 "Bug 1350221 - Support for loading Chart in Launchpad r=Honza" (tip)
merging devtools/client/netmonitor/src/assets/styles/netmonitor.css
warning: conflicts while merging devtools/client/netmonitor/src/assets/styles/netmonitor.css! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 8e1561a21b44 -d 39a3c3fbfabd: rebasing 387981:8e1561a21b44 "Bug 1350221 - Support for loading Chart in Launchpad r=Honza" (tip)
merging devtools/client/netmonitor/src/assets/styles/netmonitor.css
warning: conflicts while merging devtools/client/netmonitor/src/assets/styles/netmonitor.css! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
Pushed by rchien@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8b14e682ecb7
Support for loading Chart in Launchpad r=Honza
https://hg.mozilla.org/mozilla-central/rev/8b14e682ecb7
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: