Closed Bug 1350222 Opened 7 years ago Closed 7 years ago

Bundle missed shim modules for chrome services

Categories

(DevTools :: Netmonitor, enhancement, P1)

enhancement

Tracking

(Not tracked)

RESOLVED FIXED
Iteration:
55.2 - Apr 3

People

(Reporter: gasolin, Assigned: gasolin)

References

Details

(Whiteboard: [netmonitor])

We plan to run netmonitor on both toolbar and browser tab.

- clipboard
- Curl
- Timeline actor
- gDevtools (MDN Link)

are missing in devtools-module/devtools-sham-module
Flags: qe-verify?
Priority: -- → P2
Whiteboard: [netmonitor]
Assignee: nobody → gasolin
Status: NEW → ASSIGNED
Priority: P2 → P1
Iteration: --- → 55.2 - Apr 3
Flags: qe-verify? → qe-verify-
PART 1 - Bundle missed devtools-modules for netmonitor https://github.com/devtools-html/devtools-core/pull/290
PART 2 - Bundle missed devtools-sham-modules for netmonitor https://github.com/devtools-html/devtools-core/pull/291
I can run on browser tab 
[
1. with l10n error, which out of this bugs scope)
2. with editor disabled in properties-view, which also out of this bugs scope)
]

1.apply patch Bug 1350217 - Introduce webpack.config.js
2. patch webpack.config.js with https://gist.github.com/gasolin/bd7285ef37c412c92d564cbe9ca0032f
3. enter devtools/client/netmonitor folder
4. yarn install 
5. npm link devtools-modules devtools-sham-modules
6. yarn start
Fred, in order to not block other tasks rely on this, I've merged your webpack.config.js into bug 1350217.

There are editor and l10n not move to devtools-core yet, so I assume they will move to devtools-modules as below:

"devtools/client/sourceeditor/editor": "devtools-modules",
"devtools/shared/l10n": "devtools-modules",
devtools-modules devtools-sham-modules PR are merged

Feel free to take the webpack.config patch into Bug 1350217
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.