Closed Bug 1350228 Opened 5 years ago Closed 5 years ago

Add status bar to put summary text

Categories

(DevTools :: Netmonitor, enhancement, P1)

enhancement

Tracking

(firefox55 verified)

VERIFIED FIXED
Firefox 55
Iteration:
55.2 - Apr 3
Tracking Status
firefox55 --- verified

People

(Reporter: gasolin, Assigned: ntim)

References

Details

(Keywords: dev-doc-needed, Whiteboard: [netmonitor-reserve])

Attachments

(1 file)

In order to put a new option into the panel’s toolbar we need to move the summary information (include the perf analysis button) into a status bar - to make more space on the toolbar.Remove quotes around strings
Flags: qe-verify?
Priority: -- → P2
Whiteboard: [netmonitor]
Flags: qe-verify? → qe-verify+
QA Contact: ciprian.georgiu
Probably worth putting DOMContentLoaded and load marker times as well.
(In reply to Tim Nguyen :ntim from comment #1)
> Probably worth putting DOMContentLoaded and load marker times as well.
Yes, agree.

Honza
Assignee: nobody → ntim.bugs
Comment on attachment 8854042 [details]
Bug 1350228 - Add network monitor status bar.

https://reviewboard.mozilla.org/r/126034/#review128602

Excellent!

It would be great to turn the Network summary button into standard labels (just like the timing labels are now) and separate individual sections (number of requests, transferred, etc.) by separators (just like the timings labels). The actual button would be just the perf icon. It might be done as separate patch/bug

Thanks Tim!

Honza
Attachment #8854042 - Flags: review?(odvarko) → review+
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/aea54747dd32
Add network monitor status bar. r=Honza
Depends on: 1353057
(In reply to Jan Honza Odvarko [:Honza] from comment #5)
> Comment on attachment 8854042 [details]
> Bug 1350228 - Add network monitor status bar.
> 
> https://reviewboard.mozilla.org/r/126034/#review128602
> 
> Excellent!
> 
> It would be great to turn the Network summary button into standard labels
> (just like the timing labels are now) and separate individual sections
> (number of requests, transferred, etc.) by separators (just like the timings
> labels). The actual button would be just the perf icon. It might be done as
> separate patch/bug

Thanks for the reviews! I've filed bug 1353057 to get this done.
https://hg.mozilla.org/mozilla-central/rev/aea54747dd32
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Iteration: --- → 55.2 - Apr 3
Priority: P2 → P1
Whiteboard: [netmonitor] → [netmonitor-reserve]
Blocks: 1226566
The netmonitor now displays DOMContentLoaded and load marker times in the status bar.
Keywords: dev-doc-needed
Blocks: 1349559
Blocks: 1349561
Blocks: 1353974
Depends on: 1354472
I've managed to reproduce this issue on Nightly from 2017-03-24.

This is verified fixed on latest Nightly 55.0a1 (2017-04-09), the summary information is now displayed into the status bar. Tests were done under Windows 10 x64, Ubuntu 16.04 x64 LTS and Mac OS X 10.11.6.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.