1350228 - Add status bar to put summary text

Status: VERIFIED FIXED

(DevTools :: Netmonitor, enhancement, P1)

Description

[[e-mail]]

In order to put a new option into the panel’s toolbar we need to move the summary information (include the perf analysis button) into a status bar - to make more space on the toolbar.Remove quotes around strings

Comment 1

[Tim Nguyen :ntim]

Probably worth putting DOMContentLoaded and load marker times as well.

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

(In reply to Tim Nguyen :ntim from comment #1)
> Probably worth putting DOMContentLoaded and load marker times as well.
Yes, agree.

Honza

Comment 3

[Tim Nguyen :ntim]

Attachment: Bug 1350228 - Add network monitor status bar.

Review commit: https://reviewboard.mozilla.org/r/126034/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/126034/

Comment 4

[Tim Nguyen :ntim]

Comment on attachment 8854042 [details]
Bug 1350228 - Add network monitor status bar.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/126034/diff/1-2/

Comment 5

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8854042 [details]
Bug 1350228 - Add network monitor status bar.

https://reviewboard.mozilla.org/r/126034/#review128602

Excellent!

It would be great to turn the Network summary button into standard labels (just like the timing labels are now) and separate individual sections (number of requests, transferred, etc.) by separators (just like the timings labels). The actual button would be just the perf icon. It might be done as separate patch/bug

Thanks Tim!

Honza

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aea54747dd32
Add network monitor status bar. r=Honza

Comment 7

[Tim Nguyen :ntim]

(In reply to Jan Honza Odvarko [:Honza] from comment #5)
> Comment on attachment 8854042 [details]
> Bug 1350228 - Add network monitor status bar.
> 
> https://reviewboard.mozilla.org/r/126034/#review128602
> 
> Excellent!
> 
> It would be great to turn the Network summary button into standard labels
> (just like the timing labels are now) and separate individual sections
> (number of requests, transferred, etc.) by separators (just like the timings
> labels). The actual button would be just the perf icon. It might be done as
> separate patch/bug

Thanks for the reviews! I've filed bug 1353057 to get this done.

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/aea54747dd32

Comment 9

[Tim Nguyen :ntim]

The netmonitor now displays DOMContentLoaded and load marker times in the status bar.

Comment 10

[Matthew N. [:MattN]]

Screenshots at https://screenshots.mattn.ca/compare/?oldProject=mozilla-central&oldRev=9aacfa8081b35bb8ae1a59ce3fd9d7aba57cfc7b&newProject=mozilla-central&newRev=2a593ea93f6637df49eedc998b1f5ae4781a0f56&filter=netmonitor

Comment 11

[Ciprian Georgiu, Desktop QA]

I've managed to reproduce this issue on Nightly from 2017-03-24.

This is verified fixed on latest Nightly 55.0a1 (2017-04-09), the summary information is now displayed into the status bar. Tests were done under Windows 10 x64, Ubuntu 16.04 x64 LTS and Mac OS X 10.11.6.