Closed Bug 135023 Opened 22 years ago Closed 22 years ago

remove remaining forcehandshake workaround

Categories

(Core Graveyard :: Security: UI, defect)

Product:
Core Graveyard
Component:
Security: UI
Version:
1.0 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: jgmyers, Assigned: jgmyers)

Details

Attachments

(1 file, 1 obsolete file)

Updated fix
7.05 KB, patch
KaiE
: review+
darin.moz
: superreview+
Details | Diff | Splinter Review 
From bug 133434

This is to track removing the rest of the ssl-forcehandshake workaround.
Attached patch Proposed fix (obsolete) — — Splinter Review 

    
    

    
  
Comment on attachment 79721 [details] [diff] [review]
Proposed fix

r=bienvenu for mail part

        Attachment #79721 -
        Flags: review+

    
    

    
  
Comment on attachment 79721 [details] [diff] [review]
Proposed fix

sr=rpotts@netscape.com

        Attachment #79721 -
        Flags: superreview+

    
    

    
  
Comment on attachment 79721 [details] [diff] [review]
Proposed fix

r=rpotts@netscape.com (for the networking part)

    
    

    
  
Comment on attachment 79721 [details] [diff] [review]
Proposed fix

Thanks for working on the patch, it looks good, I just have a small request.

I think we can remove more code from nsNSSIOLayer.cpp.
The local variable infoobject and forTLSStepUp aren't required any more, they
were only used for the test that was removed with bug 133434.

        Attachment #79721 -
        Flags: needs-work+

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Updated fix
        — 
          — Splinter Review
      

    


  
Changes per review comments.

        Attachment #79721 -
        Attachment is obsolete: true

    
    

    
  
kaie: please r= updated patch

    
    

    
  
Comment on attachment 80493 [details] [diff] [review]
Updated fix

Thanks for the changes, r=kaie

        Attachment #80493 -
        Flags: review+

    
    

    
  
Comment on attachment 80493 [details] [diff] [review]
Updated fix

sr=darin

        Attachment #80493 -
        Flags: superreview+

    
    

    
  
Fix checked into trunk.

Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED

    
    

    
  
V
Status: RESOLVED → VERIFIED

    
  
Product: PSM → Core

    
  
Version: psm2.0 → 1.0 Branch
Product: Core → Core Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: