135023 - remove remaining forcehandshake workaround

Status: VERIFIED FIXED

(Core Graveyard :: Security: UI, defect)

Description

[John G. Myers]

From bug 133434

This is to track removing the rest of the ssl-forcehandshake workaround.

Comment 1

[John G. Myers]

Attachment: Proposed fix

Comment 2

[David :Bienvenu]

Comment on attachment 79721 [details] [diff] [review]
Proposed fix

r=bienvenu for mail part

Comment 3

[rpotts (gone)]

Comment on attachment 79721 [details] [diff] [review]
Proposed fix

sr=[e-mail]

Comment 4

[rpotts (gone)]

Comment on attachment 79721 [details] [diff] [review]
Proposed fix

r=[e-mail] (for the networking part)

Comment 5

[Kai Engert [:KaiE:]]

Comment on attachment 79721 [details] [diff] [review]
Proposed fix

Thanks for working on the patch, it looks good, I just have a small request.

I think we can remove more code from nsNSSIOLayer.cpp.
The local variable infoobject and forTLSStepUp aren't required any more, they
were only used for the test that was removed with bug 133434.

Comment 6

[John G. Myers]

Attachment: Updated fix

Changes per review comments.

Comment 7

[John G. Myers]

kaie: please r= updated patch

Comment 8

[Kai Engert [:KaiE:]]

Comment on attachment 80493 [details] [diff] [review]
Updated fix

Thanks for the changes, r=kaie

Comment 9

[Darin Fisher]

Comment on attachment 80493 [details] [diff] [review]
Updated fix

sr=darin

Comment 10

[John G. Myers]

Fix checked into trunk.

Comment 11

[John Unruh]

V