remove remaining forcehandshake workaround

VERIFIED FIXED

Status

VERIFIED FIXED
17 years ago
2 years ago

People

(Reporter: jgmyers, Assigned: jgmyers)

Tracking

1.0 Branch

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

7.05 KB, patch
kaie
: review+
darin.moz
: superreview+
Details | Diff | Splinter Review
(Assignee)

Description

17 years ago
From bug 133434

This is to track removing the rest of the ssl-forcehandshake workaround.
(Assignee)

Comment 1

17 years ago
Created attachment 79721 [details] [diff] [review]
Proposed fix

Comment 2

17 years ago
Comment on attachment 79721 [details] [diff] [review]
Proposed fix

r=bienvenu for mail part
Attachment #79721 - Flags: review+

Comment 3

17 years ago
Comment on attachment 79721 [details] [diff] [review]
Proposed fix

sr=rpotts@netscape.com
Attachment #79721 - Flags: superreview+

Comment 4

17 years ago
Comment on attachment 79721 [details] [diff] [review]
Proposed fix

r=rpotts@netscape.com (for the networking part)

Comment 5

17 years ago
Comment on attachment 79721 [details] [diff] [review]
Proposed fix

Thanks for working on the patch, it looks good, I just have a small request.

I think we can remove more code from nsNSSIOLayer.cpp.
The local variable infoobject and forTLSStepUp aren't required any more, they
were only used for the test that was removed with bug 133434.
Attachment #79721 - Flags: needs-work+
(Assignee)

Comment 6

17 years ago
Created attachment 80493 [details] [diff] [review]
Updated fix

Changes per review comments.
Attachment #79721 - Attachment is obsolete: true
(Assignee)

Comment 7

17 years ago
kaie: please r= updated patch

Comment 8

17 years ago
Comment on attachment 80493 [details] [diff] [review]
Updated fix

Thanks for the changes, r=kaie
Attachment #80493 - Flags: review+

Comment 9

17 years ago
Comment on attachment 80493 [details] [diff] [review]
Updated fix

sr=darin
Attachment #80493 - Flags: superreview+
(Assignee)

Comment 10

17 years ago
Fix checked into trunk.
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED

Comment 11

17 years ago
V
Status: RESOLVED → VERIFIED

Updated

14 years ago
Component: Security: UI → Security: UI
Product: PSM → Core

Updated

11 years ago
Version: psm2.0 → 1.0 Branch
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.