1350232 - Removing quotes for properties view

Status: RESOLVED DUPLICATE of bug 1258628

(DevTools :: Netmonitor, enhancement)

Description

[[e-mail]]

In Netmonitor sidebar panels, many properties has `quotes` for values. We'd like to remove "" around the properties.

Comment 1

[[e-mail]]

Ricky, could you provide more details about how to solve this bug?

Comment 2

[Ricky Chien [:rickychien] (inactive)]

I think we can simply remove Rep for representing the value at https://searchfox.org/mozilla-central/source/devtools/client/netmonitor/shared/components/properties-view.js#120-126. but return member.value directly.

Comment 3

[Moraveyo [:moraveyo]]

Can I be assigned and work on this as my "good first bug"?

Comment 4

[[e-mail]]

Sure, thanks for willing contribute! 


You can clone and build gecko by following instructions
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Simple_Firefox_build

If you need any help, just needinfo me or Ricky.

Comment 5

[Moraveyo [:moraveyo]]

Please help: how can I run test for /mozilla-central/source/devtools/client/netmonitor/shared/components/ ?

Comment 6

[Moraveyo [:moraveyo]]

Attachment: Developer Tools: Netmonitor: Removed quotes for properties view (Bug 1350232);

Review commit: https://reviewboard.mozilla.org/r/124430/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/124430/

Comment 7

[Moraveyo [:moraveyo]]

I think I finally sorted out how to run the tests for this module.
Am I right to use `./mach test devtools/client/netmonitor/test`?

Sadly the tests are broken by my patch.
I beleive it's things like `tabpanel.querySelectorAll("tr:not(.tree-section) .treeValueCell .objectBox");` returning null.

I'm not so deep into this code, please give me some clue.

Comment 8

[Ricky Chien [:rickychien] (inactive)]

Hi Elena, thanks for your contribution.

Here is our MDN doc for running mochitest https://developer.mozilla.org/en-US/docs/Mozilla/Projects/Mochitest#Running_select_tests

Yes, you can use `./mach mochitest devtools/client/netmonitor/` for testing netmonitor. (./mach test or ./mach mochitest both are the same)

or run only one or several tests by `./mach mochitest browser_net_api-calls browser_net_autoscroll`

It's tricky way for selecting our text in PropertiesView component by accessing `tabpanel.querySelectorAll("tr:not(.tree-section) .treeValueCell .objectBox");`

".objectBox" belongs to Rep but as comment 2 mentioned, we're going to remove it. So you should select an existing element to get text from element.


How to debug mochitest?

Assuming browser_net_complex-params.js is broken. I usually insert a temporary debugger statement [1] and run `./mach mochitest browser_net_complex-params --jsdebugger`. You have to run mochitest suite manually after browser opened.

[1] https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/debugger

Comment 9

[Ricky Chien [:rickychien] (inactive)]

BTW, for contributors you can join our public slack channel 

https://devtools-html.slack.com

and join #netmonitor to ask any questions.

Thanks!