Closed
Bug 1350239
Opened 7 years ago
Closed 7 years ago
SlicedInputStream has a buggy ::Seek implementation
Categories
(Core :: DOM: Core & HTML, enhancement)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: baku, Assigned: baku)
Details
Attachments
(1 file, 1 obsolete file)
|
5.43 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
Seek() doesn't consider if the reading already started or not. Plus the current position is recalculated on top of the starting point.
|
Assignee | |
Comment 1•7 years ago
|
||
Assignee: nobody → amarchesini
Attachment #8850869 -
Flags: review?(bugs)
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8850869 [details] [diff] [review] sliced_bug.patch This code could in general use CheckedInt. Not about this bug, but worth to file another bug. Do we need this in Aurora. How did you find this issue? Can we get a test for this?
Attachment #8850869 -
Flags: review?(bugs) → review+
|
|
Assignee | |
Comment 3•7 years ago
|
||
> How did you find this issue? Can we get a test for this?
PBlob refactoring. I'll extend the gtests before landing the patch.|
|
Assignee | |
Comment 4•7 years ago
|
||
Also END is buggy if the length is > then the real size of the inputStream +tests
Attachment #8850869 -
Attachment is obsolete: true
Attachment #8850910 -
Flags: review?(bugs)
|
|
||
Comment 5•7 years ago
|
||
Comment on attachment 8850910 [details] [diff] [review] sliced_bug.patch Still asking, do we need all this for Aurora too? I assume so. Weird indentation inside 'case NS_SEEK_END:'
Attachment #8850910 -
Flags: review?(bugs) → review+
Pushed by amarchesini@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/a506737fb2a0 SlicedInputStream::Seek must set correct position in the source stream, r=smaug
|
||
Comment 7•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/a506737fb2a0
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•