Closed
Bug 1350308
Opened 7 years ago
Closed 7 years ago
Incremental marking validator doesn't work in release builds
Categories
(Core :: JavaScript: GC, enhancement)
Core
JavaScript: GC
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: jonco, Assigned: jonco)
Details
Attachments
(1 file)
|
1.43 KB,
patch
|
sfink
:
review+
|
Details | Diff | Splinter Review |
MarkingValidator in jsgc.cpp uses MOZ_ASSERTs for its checks so even though it is build conditionally on JS_GC_ZEAL, it won't actually do anything in release builds. This is also causing build warnings.
|
Assignee | |
Comment 1•7 years ago
|
||
We just need to use release asserts here.
Assignee: nobody → jcoppeard
Attachment #8851587 -
Flags: review?(sphink)
|
||
Updated•7 years ago
|
Attachment #8851587 -
Flags: review?(sphink) → review+
Pushed by jcoppeard@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/5decfa8fbb5f Make incremental marking validator work in release builds r=sfink
|
||
Comment 3•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/5decfa8fbb5f
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•