Fix uninitialized local variables in updatehelper.cpp

RESOLVED FIXED in Firefox 55

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: xiaoyin.l, Assigned: xiaoyin.l)

Tracking

unspecified
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
In IsUnpromptedElevation function, if |success| is FALSE, then |consent| and |secureDesktop| are not initialized. But later, in this line:
  isUnpromptedElevation = !consent && !secureDesktop;
their values are used, which is an undefined behavior.
Comment hidden (mozreview-request)
(Assignee)

Updated

2 years ago
Attachment #8850930 - Flags: review?(robert.strong.bugs)
Comment on attachment 8850930 [details]
Bug 1350309 - Fix uninitialized variables in updatehelper.cpp

https://reviewboard.mozilla.org/r/123448/#review135378
Attachment #8850930 - Flags: review?(robert.strong.bugs) → review+

Comment 3

2 years ago
Pushed by rstrong@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/55b7d1884d99
Fix uninitialized variables in updatehelper.cpp r=rstrong
https://hg.mozilla.org/mozilla-central/rev/55b7d1884d99
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.