1350371 - jsapi-test testNewContext complains about leaking JSRuntime

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement)

Description

[Jon Coppeard (:jonco)]

Running this jsapi test gives the following output:

testNewContext
Test new context: started
Test new context: finished with 35 allocations
TEST-PASS | testNewContext | ok
WARNING: YOU ARE LEAKING THE WORLD (at least one JSRuntime and everything alive inside it, that is) AT JS_ShutDown TIME.  FIX THIS!

Passed: ran 1 tests.

Comment 1

[Jon Coppeard (:jonco)]

Attachment: bug1350371-jsruntime-leak

The problem is that the live runtime count is updated in JSRuntime::destroyRuntime, but that isn't always called if we fail to initialize a new runtime/context.

The patch moves the count update to the destructor for symmetry with the constructor, adds assertions to make sure we always call destoryRuntime when init has previously been called and updates js::NewContext call destroyRuntime appropriately.

Comment 2

[Jan de Mooij [:jandem]]

Comment on attachment 8851028 [details] [diff] [review]
bug1350371-jsruntime-leak

Review of attachment 8851028 [details] [diff] [review]:
-----------------------------------------------------------------

Nice, thanks!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e370a8a25bb1
Call destroyRuntime when initialization fails in js::NewContext r=jandem

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e370a8a25bb1