Closed Bug 1350413 Opened 7 years ago Closed 7 years ago

Move macosx64 opt builds to buildbot-bridge

Categories

(Firefox Build System :: Task Configuration, task, P1)

Product:
Firefox Build System
Component:
Task Configuration
Platform:
x86_64
macOS
Type:
task

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla55

People

(Reporter: wcosta, Assigned: wcosta)

References

Details

User Story

Until bug 1338651 is fixed, we need to build macosx64 opt through buildbot-bridge.
I never did build configuration with the new in tree syntax, but from what I see,
it has to change macosx.yml file [1]:

* worker-type should be buildbot-bridge/buildbot-bridge
* implementation should be buildbot-bridge
* symbol be removed

and it has to add a buildbot-bridge entry to mozharness.py [1]. The function can be based on [3].

[1] https://dxr.mozilla.org/mozilla-central/source/taskcluster/ci/build/macosx.yml#25-46
[2] https://dxr.mozilla.org/mozilla-central/source/taskcluster/taskgraph/transforms/job/mozharness.py
[3] https://dxr.mozilla.org/mozilla-central/source/taskcluster/taskgraph/transforms/job/mozharness_test.py#340-424

Attachments

(3 files, 4 obsolete files)

Bug 1350413 part 1: move macosx64/opt build to buildbot-bridge.
59 bytes, text/x-review-board-request
dustin
: review+
Details
Bug 1350413 part 2: Fix generic-worker configuration.
59 bytes, text/x-review-board-request
dustin
: review+
Details
bug1350413morph.patch
1.00 KB, patch
wcosta
: feedback+
Details | Diff | Splinter Review 
      No description provided.
NI :dustin to double check if that makes sense.
Flags: needinfo?(dustin)
Assignee: nobody → wcosta
Flags: needinfo?(dustin)
I think that makes sense.  I'm sure there will be some mozharness job attributes that don't translate, but that's OK -- anything BBB is kinda a hack and temporary anyway.
Status: NEW → ASSIGNED
Depends on: 1353376
Comment on attachment 8854400 [details]
Bug 1350413 part 1: move macosx64/opt build to buildbot-bridge.

https://reviewboard.mozilla.org/r/126350/#review128906
Attachment #8854400 - Flags: review?(dustin) → review+
Attached file pr-45 (obsolete) — 

        Attachment #8855941 -
        Flags: review?(catlee)

    
    

    
  
Do we still want to do this? Or would passing in the upload task's id to the mozharness job work?

    
    

    
  
(In reply to Chris AtLee [:catlee] from comment #6)
> Do we still want to do this? Or would passing in the upload task's id to the
> mozharness job work?

I tried this but it didn't work, because mozharness wouldn't be able to claim the task because BBB already did.

    
    

    
  
wcosta can this patch be modified so we only switch to the bb builds on the holly branch so we can get that sorted there before changing this on all branches?
Flags: needinfo?(wcosta)

    
    

    
  
(In reply to Kim Moir [:kmoir] from comment #8)
> wcosta can this patch be modified so we only switch to the bb builds on the
> holly branch so we can get that sorted there before changing this on all
> branches?

Yes, I think so.
Flags: needinfo?(wcosta)

    
    

    
      
  

    
    

    
      
  


  

    
    

    
      
  

    
    

    
      
  


  

    
    

    
      
  

    
    

    
      
  

        Attachment #8855941 -
        Flags: review?(catlee)

    
    

    
  
Comment on attachment 8859770 [details]
Bug 1350413 part 2: Fix generic-worker configuration.

https://reviewboard.mozilla.org/r/131768/#review134896

        Attachment #8859770 -
        Flags: review?(dustin) → review+
Depends on: 1358188

    
    

    
      
  

    
    

    
      
  

    
  

        Attachment #8860036 -
        Attachment is obsolete: true

        Attachment #8860036 -
        Flags: review?(kmoir)

    
  

        Attachment #8855941 -
        Attachment is obsolete: true

    
    

    
  

      
      
      
      

        Attached patch
          
          
        bug1350413morph.patch (obsolete)
        — 
          — Splinter Review
      

    


  
I'm trying to schedule macosx builds via tc on holly in bug 1353376

see the issues starting here
https://bugzilla.mozilla.org/show_bug.cgi?id=1353376#c47

I needed this patch to make it work and move on the next error message.

        Attachment #8861545 -
        Flags: feedback?(wcosta)

    
    

    
  


  
this patch is better

        Attachment #8861545 -
        Attachment is obsolete: true

        Attachment #8861545 -
        Flags: feedback?(wcosta)

        Attachment #8861559 -
        Flags: feedback?(wcosta)

    
    

    
  
So an opt build ran on holly via bbb but it failed to upload

https://archive.mozilla.org/pub/firefox/tinderbox-builds/holly-macosx64/1493145050/holly-macosx64-bm82-build1-build0.txt.gz

https://treeherder.allizom.org/#/jobs?repo=holly&revision=8cf09cae5fcfe674c32aeb5e4e59a0d89f5b54e6&selectedJob=87995820

Not sure what is happening here but I'll let wcosta comment because I am focusing the work in bug  	1353376
Flags: needinfo?(wcosta)

    
    

    
  
Comment on attachment 8861559 [details] [diff] [review]
bug1350413morph.patch

Review of attachment 8861559 [details] [diff] [review]:
-----------------------------------------------------------------

Oh, dynamic languages... Thanks, will update my patch.

        Attachment #8861559 -
        Flags: feedback?(wcosta) → feedback+

    
    

    
  
(In reply to Kim Moir [:kmoir] from comment #21)
> So an opt build ran on holly via bbb but it failed to upload
> 
> https://archive.mozilla.org/pub/firefox/tinderbox-builds/holly-macosx64/
> 1493145050/holly-macosx64-bm82-build1-build0.txt.gz
> 
> https://treeherder.allizom.org/#/
> jobs?repo=holly&revision=8cf09cae5fcfe674c32aeb5e4e59a0d89f5b54e6&selectedJob
> =87995820
> 
> Not sure what is happening here but I'll let wcosta comment because I am
> focusing the work in bug  	1353376

/me /o\

Not sure what's happening, but it seems unrelated to our work. Maybe a side effect of scheduling BB off?
Anyway, I did a re-trigger to be sure it is not a transient problem.
Flags: needinfo?(wcosta)

    
    

    
  
(In reply to Wander Lairson Costa [:wcosta] from comment #23)
> (In reply to Kim Moir [:kmoir] from comment #21)
> > So an opt build ran on holly via bbb but it failed to upload
> > 
> > https://archive.mozilla.org/pub/firefox/tinderbox-builds/holly-macosx64/
> > 1493145050/holly-macosx64-bm82-build1-build0.txt.gz
> > 
> > https://treeherder.allizom.org/#/
> > jobs?repo=holly&revision=8cf09cae5fcfe674c32aeb5e4e59a0d89f5b54e6&selectedJob
> > =87995820
> > 
> > Not sure what is happening here but I'll let wcosta comment because I am
> > focusing the work in bug  	1353376
> 
> /me /o\
> 
> Not sure what's happening, but it seems unrelated to our work. Maybe a side
> effect of scheduling BB off?
> Anyway, I did a re-trigger to be sure it is not a transient problem.

Looking a little deeper, it feels like we need to add stage_server and stage_username here [1]

[1] https://dxr.mozilla.org/mozilla-central/source/testing/mozharness/configs/builds/branch_specifics.py#257
Flags: needinfo?(kmoir)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        bug1350413mh.patch (obsolete)
        — 
          — Splinter Review
      

    


  
I landed this patch yesterday and the builds are all green

https://treeherder.allizom.org/#/jobs?repo=holly&revision=8e4db90d284504d1a84948eccaf62aeec3fd10c6
Flags: needinfo?(kmoir)

    
    

    
  
wcosta: I have reviewed patches in bug 1353376 now to enable the buildbot scheduling changes to support this.  Do you want to coordinate a time to land these patches and this bug together to reduce the number of duplicate jobs?
Flags: needinfo?(wcosta)

    
    

    
      
  

    
    

    
      
  

    
    

    
  
(In reply to Kim Moir [:kmoir] from comment #26)
> wcosta: I have reviewed patches in bug 1353376 now to enable the buildbot
> scheduling changes to support this.  Do you want to coordinate a time to
> land these patches and this bug together to reduce the number of duplicate
> jobs?

This how I see:

1. I land this bug
2. Wait bug be resolve (i.e. reach m-c)
3. Wait for next merge Window.
4. Land bug 1353376
5. Wait for bug be resolved
6. Land bug 1330310
7. Game over
Flags: needinfo?(wcosta)

    
    

    
  
Okay, sounds good.

    
    

    
  
Not only builds, but tests also duplicate, this might be a problem. Should we hold so until everything gets landed? I suppose that are no other option? https://treeherder.mozilla.org/#/jobs?repo=try&revision=1dd9fb54f0c8
Flags: needinfo?(kmoir)

    
    

    
  
What we could do is 
1) land your patches on inbound first thing in the morning when load is low
2) I could land a patch to fix the scheduling on trunk excluding m-c
3) wait for uplift
4) I could land a patch to fix the scheduling on trunk including m-c

This would reduce the number of duplicate jobs while waiting for uplift
Flags: needinfo?(kmoir)

    
    

    
  
(In reply to Kim Moir [:kmoir] from comment #32)
> What we could do is 
> 1) land your patches on inbound first thing in the morning when load is low
> 2) I could land a patch to fix the scheduling on trunk excluding m-c
> 3) wait for uplift
> 4) I could land a patch to fix the scheduling on trunk including m-c
> 
> This would reduce the number of duplicate jobs while waiting for uplift

Ok, I will land tomorrow first thing in the morning. Do I need to land necessarily in inbound or could it be autoland?

    
    

    
  
Either autoland or m-i are fine. I'll check early tomorrow and see if your patches have landed, so I can land my patches asap.

    
    

    
  
Pushed by wcosta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/971b9548d84c
part 1: move macosx64/opt build to buildbot-bridge. r=dustin
https://hg.mozilla.org/integration/autoland/rev/6b5f20da8bc9
part 2: Fix generic-worker configuration. r=dustin

    
    

    
  
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/mozilla-central/rev/d332dec2afe8
part 1: move macosx64/opt build to buildbot-bridge. r=dustin
https://hg.mozilla.org/mozilla-central/rev/0b255199db9d
part 2: Fix generic-worker configuration. r=dustin a=fix-for-buildbot-bridge-on-osx

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/971b9548d84c
https://hg.mozilla.org/mozilla-central/rev/6b5f20da8bc9
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55

        Attachment #8862412 -
        Attachment is obsolete: true

    
  
Product: TaskCluster → Firefox Build System

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: