Closed Bug 1350414 Opened 4 years ago Closed 3 years ago

Define HAVE_POINTER_LOCALTIME_R for BSDs

Categories

(NSPR :: NSPR, enhancement)

4.15
Unspecified
FreeBSD
enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jbeich, Assigned: jbeich)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

DragonFly, FreeBSD, NetBSD and OpenBSD have the following declaration:

  struct tm *localtime_r(const time_t *, struct tm *);

which is same as on Linux and OS X, so chase https://hg.mozilla.org/projects/nspr/rev/1f5630faef26
Attached patch v1Splinter Review
Tests show no difference. NSPR (unlike NSS) doesn't have a dedicated Try server.
Attachment #8851090 - Flags: review?(kaie)
Blocks: 1350426
Comment on attachment 8851090 [details] [diff] [review]
v1

Let's try another reviewer.
Attachment #8851090 - Flags: review?(kaie) → review?(ted)
Blocks: 512076
Comment on attachment 8851090 [details] [diff] [review]
v1

I have resigned as NSPR module owner. Sorry for the inconvenience.
Attachment #8851090 - Flags: review?(ted)
Comment on attachment 8851090 [details] [diff] [review]
v1

r=kaie
Attachment #8851090 - Flags: review+
https://hg.mozilla.org/projects/nspr/rev/7fc298409c44
Assignee: nobody → jbeich
Target Milestone: --- → 4.16
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.