Define HAVE_POINTER_LOCALTIME_R for BSDs

RESOLVED FIXED in 4.16

Status

enhancement
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jbeich, Assigned: jbeich)

Tracking

(Blocks 1 bug)

4.15
4.16
Unspecified
FreeBSD
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Assignee

Description

2 years ago
DragonFly, FreeBSD, NetBSD and OpenBSD have the following declaration:

  struct tm *localtime_r(const time_t *, struct tm *);

which is same as on Linux and OS X, so chase https://hg.mozilla.org/projects/nspr/rev/1f5630faef26
Assignee

Comment 1

2 years ago
Posted patch v1Splinter Review
Tests show no difference. NSPR (unlike NSS) doesn't have a dedicated Try server.
Attachment #8851090 - Flags: review?(kaie)
Assignee

Updated

2 years ago
Blocks: 1350426
Assignee

Comment 2

2 years ago
Comment on attachment 8851090 [details] [diff] [review]
v1

Let's try another reviewer.
Attachment #8851090 - Flags: review?(kaie) → review?(ted)
Assignee

Updated

2 years ago
Blocks: 512076
Comment on attachment 8851090 [details] [diff] [review]
v1

I have resigned as NSPR module owner. Sorry for the inconvenience.
Attachment #8851090 - Flags: review?(ted)
Comment on attachment 8851090 [details] [diff] [review]
v1

r=kaie
Attachment #8851090 - Flags: review+
https://hg.mozilla.org/projects/nspr/rev/7fc298409c44
Assignee: nobody → jbeich
Target Milestone: --- → 4.16

Updated

2 years ago
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.