1350419 - console.assert "condition" argument should default to false

Status: RESOLVED DUPLICATE of bug 1357473

(DevTools :: Console, enhancement, P2)

Description

[Tom Tromey :tromey]

According to https://console.spec.whatwg.org/#console-namespace,
console.assert's "condition" argument should default to "false".
For us, it is currently required.

I think this is just a matter of changing the webidl and writing a test case.
https://dxr.mozilla.org/mozilla-central/rev/e03e0c60462c775c7558a1dc9d5cf2076c3cd1f9/dom/webidl/Console.webidl#32

Comment 1

[Federico Padua [:fedepad]]

(In reply to Tom Tromey :tromey from comment #0)
> According to https://console.spec.whatwg.org/#console-namespace,
> console.assert's "condition" argument should default to "false".
> For us, it is currently required.
> 
> I think this is just a matter of changing the webidl and writing a test case.
> https://dxr.mozilla.org/mozilla-central/rev/
> e03e0c60462c775c7558a1dc9d5cf2076c3cd1f9/dom/webidl/Console.webidl#32

I can help with that, but I have no idea how to write the test...

Wouldn't removing "false" from [1] do it for the test part? If not I need some directions...

[1]: https://dxr.mozilla.org/mozilla-central/source/dom/tests/browser/browser_ConsoleAPITests.js#230

Thanks!

Comment 2

[Tom Tromey :tromey]

(In reply to Federico Padua [:fedepad] from comment #1)

> Wouldn't removing "false" from [1] do it for the test part? 

I think adding a new test there, that just calls "console.assert()", would be good enough.