1350428 - Pings being throttled though throttling set to 1

Status: RESOLVED INVALID

(Toolkit :: Telemetry, defect)

Description

[John Dorlus [:Silne30]]

I am running a marionette test with a custom profile with throttling set to 1. An addon is installed but the ping is still not sent due to throttling.

Comment 1

[Alessio Placitelli [:Dexter]]

(In reply to John Dorlus [:Silne30] from comment #0)
> I am running a marionette test with a custom profile with throttling set to
> 1. An addon is installed but the ping is still not sent due to throttling.

Please post the Telemetry logs, otherwise there's no way for us to figure out what's going on.
Would you mind also attaching the code you're using to set the pref/your current patch?

Comment 2

[John Dorlus [:Silne30]]

Attachment: Test logs

Comment 3

[John Dorlus [:Silne30]]

Attachment: code for prefs

Comment 4

[Alessio Placitelli [:Dexter]]

(In reply to John Dorlus [:Silne30] from comment #3)
> Created attachment 8852069 [details]
> code for prefs

This attachment is not setting the "toolkit.telemetry.minSubsessionLength" as suggested in bug 1301776 comment 21. Is this the wrong attachment or you didn't set it at all?

Comment 5

[John Dorlus [:Silne30]]

Attachment: Correct log with pref set

Comment 6

[John Dorlus [:Silne30]]

Attachment: Code to set prefs.

I also checked the value of the pref in the test and it does show 0. But still getting throttled.

Comment 7

[John Dorlus [:Silne30]]

Something interesting to note: This throttling does not affect the sending of the testpilot ping when you install a testpilot addon. Not sure if that helps you diagnose.

Comment 8

[John Dorlus [:Silne30]]

I also loaded a profile with the pref set in the actual profile. Still no go.

Comment 9

[Alessio Placitelli [:Dexter]]

(In reply to John Dorlus [:Silne30] from comment #7)
> Something interesting to note: This throttling does not affect the sending
> of the testpilot ping when you install a testpilot addon. Not sure if that
> helps you diagnose.

That's expected. The "testpilot" ping is not a main ping and has nothing to do with the environment changes.

Comment 10

[Alessio Placitelli [:Dexter]]

(In reply to John Dorlus [:Silne30] from comment #6)
> Created attachment 8852216 [details]
> Code to set prefs.
> 
> I also checked the value of the pref in the test and it does show 0. But
> still getting throttled.

I manually checked and setting the pref to 0 + restarting Firefox allows to overcome throttling.

The "toolkit.telemetry.minSubsessionLength" preference must be set in the profile before Firefox starts (or Firefox must be restarted after to enforce it): this is exactly the same as the "initDelay" pref.

So, if the logs still report throttling, it's probably because the pref didn't contain 0 when Firefox started up. As far as I can tell, that's the only reason why the throttling message can be printed [1].

If you're building your own version of Firefox, you could just add

> dump("\n**** DEBUG Minimum subsession length is " + MIN_SUBSESSION_LENGTH_MS + "\n");

Inside the "if" branch at [1] to see if the value is what you are setting.

[1] - http://searchfox.org/mozilla-central/rev/7419b368156a6efa24777b21b0e5706be89a9c2f/toolkit/components/telemetry/TelemetrySession.jsm#2092

Comment 11

[John Dorlus [:Silne30]]

Updating mozilla-central fixed this.