1350441 - stylo: fix a few restyle state coherency bugs

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P1)

Description

[Bobby Holley (:bholley)]

Splitting these off from my work in bug 1331047.

Comment 1

[Bobby Holley (:bholley)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=078d6e46f079958544311d77d87c261481e2b2ee

Comment 2

[Bobby Holley (:bholley)]

Attachment: Part 1 - Centralize note_dirty_descendants implementation, and fully propagate dirty_descendants in resolve_style. v1

The current code can leave the tree in an inconsistent state, with the dirty
descendants bit not fully propagated.

MozReview-Commit-ID: ALI6etmlrDa

Comment 3

[Bobby Holley (:bholley)]

Attachment: Part 2 - Make ServoRestyleManager::ClearServoDataFromSubtree a bit smarter. v1

There's no reason to traverse the entire subtree if we encounter an unstyled section.

MozReview-Commit-ID: 7WeMTI73wR9

Comment 4

[Bobby Holley (:bholley)]

Attachment: Part 3 - Clear servo data when tearing down frames for DestroyFramesFor. v1

MozReview-Commit-ID: DWwu8FqSjdj

Comment 5

[Cameron McCormack (:heycam)]

Comment on attachment 8851146 [details] [diff] [review]
Part 3 - Clear servo data when tearing down frames for DestroyFramesFor. v1

Review of attachment 8851146 [details] [diff] [review]:
-----------------------------------------------------------------

Seems reasonable...

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/abcdc4570f03
Make ServoRestyleManager::ClearServoDataFromSubtree a bit smarter. r=heycam
https://hg.mozilla.org/integration/autoland/rev/d09572f941c5
Clear servo data when tearing down frames for DestroyFramesFor. r=heycam

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/abcdc4570f03
https://hg.mozilla.org/mozilla-central/rev/d09572f941c5