Closed Bug 1350441 Opened 3 years ago Closed 3 years ago

stylo: fix a few restyle state coherency bugs

Categories

(Core :: CSS Parsing and Computation, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: bholley, Assigned: bholley)

References

Details

Attachments

(3 files)

Splitting these off from my work in bug 1331047.
Summary: stylo: fix a few bugs where the tree gets into an inconsistent restyle state → stylo: fix a few restyle state coherency bugs
The current code can leave the tree in an inconsistent state, with the dirty
descendants bit not fully propagated.

MozReview-Commit-ID: ALI6etmlrDa
Attachment #8851144 - Flags: review?(cam)
There's no reason to traverse the entire subtree if we encounter an unstyled section.

MozReview-Commit-ID: 7WeMTI73wR9
Attachment #8851145 - Flags: review?(cam)
MozReview-Commit-ID: DWwu8FqSjdj
Attachment #8851146 - Flags: review?(cam)
Attachment #8851144 - Flags: review?(cam) → review+
Attachment #8851145 - Flags: review?(cam) → review+
Comment on attachment 8851146 [details] [diff] [review]
Part 3 - Clear servo data when tearing down frames for DestroyFramesFor. v1

Review of attachment 8851146 [details] [diff] [review]:
-----------------------------------------------------------------

Seems reasonable...
Attachment #8851146 - Flags: review?(cam) → review+
Pushed by bholley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/abcdc4570f03
Make ServoRestyleManager::ClearServoDataFromSubtree a bit smarter. r=heycam
https://hg.mozilla.org/integration/autoland/rev/d09572f941c5
Clear servo data when tearing down frames for DestroyFramesFor. r=heycam
https://hg.mozilla.org/mozilla-central/rev/abcdc4570f03
https://hg.mozilla.org/mozilla-central/rev/d09572f941c5
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.