Open Bug 1350456 Opened 3 years ago Updated 3 years ago

DocumentTimeline::Constructor() can throw a Gecko-specific error code

Categories

(Core :: DOM: Animation, enhancement, P3)

enhancement

Tracking

()

Tracking Status
firefox55 --- affected

People

(Reporter: botond, Unassigned)

References

Details

DocumentTimeline::Constructor() contains a line [1] that does:

  aRv.Throw(NS_ERROR_FAILURE);

Boris made some observations about this in bug 1321428 comment 47:

> This is clearly not a per-spec thing, right, since the spec 
> has no concept of NS_ERROR_FAILURE?  This needs at least a 
> comment, eg. about why we can end up in this situation.

and bug 1321428 comment 62:

> That said, in practice maybe this can only return failure if 
> we're calling the constructor from a torn-down window for 
> which GetDoc() returns null, which is a situation the spec 
> thinks can't exist.  So it's possible that returning a 
> Gecko-specific error code is the right thing here; needs a 
> comment.

Filing this bug to track either changing the error code, or adding a comment.

Whatever resolution we adopt here should apply to ScrollTimeline::Constructor() as well, which contains (or will contain shortly, when it lands) the same line.

[1] http://searchfox.org/mozilla-central/rev/7419b368156a6efa24777b21b0e5706be89a9c2f/dom/animation/DocumentTimeline.cpp#57
See Also: → 1321428
Priority: -- → P3
You need to log in before you can comment on or make changes to this bug.