Closed Bug 1350471 Opened 5 years ago Closed 5 years ago
Timer method to ns IUpdate Timer Manager
59 bytes, text/x-review-board-request
34 bytes, text/plain
Currently nsIUpdateTimerManager has a `registerTimer` method, but does not provide a method to unregister: http://searchfox.org/mozilla-central/rev/7419b368156a6efa24777b21b0e5706be89a9c2f/toolkit/components/timermanager/nsIUpdateTimerManager.idl To be useful from hot-reloadable code like add-ons, we should add an "unregisterTimer" method.
Assignee: nobody → rhelmer
Status: NEW → ASSIGNED
Comment on attachment 8851331 [details] Bug 1350471 - provide an unregisterTimer function for nsIUpdateTimerManager https://reviewboard.mozilla.org/r/123654/#review126424 Well that was easy!
Attachment #8851331 - Flags: review?(dtownsend) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/0a4d80866b40 provide an unregisterTimer function for nsIUpdateTimerManager r=mossop
Approval Request Comment [Feature/Bug causing the regression]: bug 1350471 [User impact if declined]: enable add-ons to use built-in update timer. without this patch, add-ons will leak on upgrade since they cannot unregister timers. [Is this code covered by automated tests?]: yes [Has the fix been verified in Nightly?]: no [Needs manual test from QE? If yes, steps to reproduce]: no [List of other uplifts needed for the feature/fix]: none [Is the change risky?]: no [Why is the change risky/not risky?]: trivial change (new "unregister" function) [String changes made/needed]: none
Sounds like this affects all current branches and has been an issue for a while.
Comment on attachment 8851331 [details] Bug 1350471 - provide an unregisterTimer function for nsIUpdateTimerManager The uplift request should be for this patch. This should help fix potential memory leaks from system add-ons.
Setting qe-verify- based on Robert's assessment on manual testing needs (see Comment 6) and the fact that this fix has automated coverage.
You need to log in before you can comment on or make changes to this bug.