1350510 - Cleanup tab strip reorder tabs transparency issues

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: Theme and Visual Design, enhancement, P5)

Description

[Tom Klein]

This is a tablet tab strip issue.

We lose "pressed" state when a tab enters dragging mode (i.e. once it's long pressed), so tabs being dragged in the tab strip are in their default state.  That means when we drag an unselected tab we have a transparent background, which doesn't look very nice as you drag your transparent tab over other tabs.  See attachment 8834564 [details] for example.

Comment 1

[Tom Klein]

As a first step I've created a patch that maintains the "pressed" state as long as the tab is actually pressed during a drag.

Anthony, could you give it a try and see what you think?  apk here: https://queue.taskcluster.net/v1/task/PcKo1n3zQ3eRO3aFI6L0IA/runs/0/artifacts/public/build/target.apk (warning: that's from a WIP patch that will crash if you try to move tabs in the tabs tray).

Even with the pressed state issue taken care of, there are still two remaining issues we may or may not want to address.
1) Once the user lifts their finger from the drag, they're no longer in the pressed state, so if you're dragging an unselected tab and you lift your finger to end the drag, that tab reverts to a transparent background during its animation to its final position.  Thoughts on that?  (It would be easy enough to extend the pressed state until the tab finishes its final animation, but then we're somewhat abusing the pressed state...)

2) If the user has a theme applied then even the pressed state background is partially transparent, so even with this fix you can still somewhat see background tabs as you reorder.  Thoughts on that?

If we're not okay with 1) and/or 2), the fix will probably be to add another "dragging" state in addition to the "pressed" state so that we have finer control over background colors when we're dragging (and maybe pressed).

Comment 2

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Thanks Tom! that sounds like a great start. But I'm going to need some time to get to this. 

I'm also going to CC carol since she's been helping us out on the visual design side so much :)

Leaving NI on so I don't forget.

Comment 3

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Joe, this seems Photon related? thoughts?

Comment 4

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

visual enhancement for Tablet use case

Comment 5

[Ioana Chiorean]

Wesly, Sebastian - do we have a timeframe for this as the feature will be released soon?

Comment 6

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

relay the NI

Comment 7

[Sebastian Kaspari (:sebastian; :pocmo)]

Setting tracking flag.

I wonder whether something has changed here since we landed the Photon changes?

Comment 8

[Wesly Huang (EPM)]

Nevin, maybe this is covered with your tap tray UI refresh? If not we may consider to have it in the next sprint, or?

Comment 9

[Nevin Chen(Not active on Bugzilla)]

The latest design has no "dragging mode" either. At first when they are long clicked, they'll have transparent background. Once they start dragging, they'll show their original state. And lwt won't change the background.
I think we need Carol's widsom on this.

Comment 10

[Tom Klein]

Attachment: Bug 1350510 - WIP

Review commit: https://reviewboard.mozilla.org/r/166890/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/166890/

Comment 11

[Tom Klein]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=884646893f2e

Comment 12

[Tom Klein]

I posted my WIP code from 5 months ago; see comment 1 for what that fixes and what it doesn't.  APK from a new try run if anyone wants to give it a try: https://queue.taskcluster.net/v1/task/UimS4fCpSEmyaIqM_uLBPQ/runs/0/artifacts/public/build/target.apk

Comment 13

[Nevin Chen(Not active on Bugzilla)]

Hi Carol
Could you please help take a look at the solution comment 12? It think it's nice:)

Comment 14

[Carol Huang [:Carol]]

Hi Nevin, 
the apk on comment 12 since not working. could you provide me a new one to check? Thank you!

Comment 15

[Nevin Chen(Not active on Bugzilla)]

Hi Tom
Try build didn't pass. Can you help generate a test apk for UX to review?
Thanks!

Comment 16

[Tom Klein]

Comment on attachment 8895643 [details]
Bug 1350510 - WIP

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/166890/diff/1-2/

Comment 17

[Tom Klein]

New test apk here: https://queue.taskcluster.net/v1/task/Qg5HDptmT7mfvlBl-MAnrQ/runs/0/artifacts/public/build/target.apk

Comment 18

[Firefox Bug Husbandry Bot]

Re-triaging per https://bugzilla.mozilla.org/show_bug.cgi?id=1473195

Needinfo :susheel if you think this bug should be re-triaged.

Comment 19

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.