1350564 - Crash in mozilla::dom::quota::UsageRequest::GetResult

Status: RESOLVED FIXED

(Core :: Storage: Quota Manager, defect)

Description

[Calixte Denizet (:calixte)]

This bug was filed from the Socorro interface and is 
report bp-c3140866-5f90-4723-8adb-e5fcc2170324.
=============================================================

There are 2 crashes on nightly 55 with buildid 20170324030205. In analyzing the backtrace, the regression may have been introduced by patch [1] to fix bug 1348660.

[1] https://hg.mozilla.org/mozilla-central/rev?node=ea3c6e12b49991ae80061d66dec24e28ccfeb237

Comment 1

[Jan Varga [:janv]]

I think I know what the problem is, let me fix it.

Comment 3

[Tomer Cohen :tomer]

(In reply to Calixte Denizet (:calixte) from comment #0)
> There are 2 crashes on nightly 55 with buildid 20170324030205. In analyzing
Earliest build according to crash-stats is 20170323110205. Bug has been spotted on Windows 7/8.1/10 as well as Linux. According to the comments, users were able to reproduce this by accessing the site information panel or viewing the site certificate. I am able to reproduce this on my machine.

Comment 4

[Mats Palmgren (inactive)]

There are also some crashes in mozilla::dom::quota::Request::GetResult that have similar stacks.
e.g. bp-e21344db-f2eb-49ec-8268-84a510170414
First report for that signature is build 20170329071901.

Comment 5

[Marcia Knous [:marcia]]

Tracking 55+ for this crash regression.

Comment 6

[Jan Varga [:janv]]

Attachment: patch

Comment 7

[Bevis Tseng[:bevis][:btseng](Exited)]

Comment on attachment 8859034 [details] [diff] [review]
patch

Review of attachment 8859034 [details] [diff] [review]:
-----------------------------------------------------------------

nice catch!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/65c632f7889f
Don't try to addref a null mResult in Request::GetResult and UsageRequest::GetResult (mResult can be null when mHaveResultOrErrorCode is true); r=btseng

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/65c632f7889f

Comment 10

[Jan Varga [:janv]]

Attachment: patch for ESR52

Comment 11

[Jan Varga [:janv]]

Comment on attachment 8911854 [details] [diff] [review]
patch for ESR52

[Approval Request Comment]
If this is not a sec:{high,crit} bug, please state case for ESR consideration: This is needed for bug 1047098 which already has ESR52 approval.
User impact if declined: See bug 1047098.
Fix Landed on Version: 55
Risk to taking this patch (and alternatives if risky): Low
String or UUID changes made by this patch: None

Comment 12

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8911854 [details] [diff] [review]
patch for ESR52

Needed for the fix for bug 1047098 so let's take it for ESR 52.5.0.

Comment 13

[Liz Henry (:lizzard) (relman/hg->git project)]

Note, this was marked unaffected, tweaking the flag as I guess the status changes as a result of the other uplifts to ESR52 for this bug.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr52/rev/2abf26abb2a2