Windows automation builds appear to be using different versions of Windows SDKs than you get by installing the specified build pre-requisites.

RESOLVED FIXED

Status

Release Engineering
General Automation
P5
normal
RESOLVED FIXED
11 months ago
7 months ago

People

(Reporter: WG9s, Unassigned)

Tracking

unspecified
x86_64
Windows 10

Firefox Tracking Flags

(firefox56 fixed)

Details

(Reporter)

Description

11 months ago
OK. so what is going on here?  Bug 1337331 landed on mozilla-central and passed automation builds and tests just fine.  However, using the supposed Windows build requirements (and it is is actually Mozilla Build that is the issue) it fails miserably.  So why do we suddenly have a divergence between what is being used in automation and what we are provided to developers as build tools?
Can you elaborate please? What tools did you mean?

BTW, we cannot provide (read distribute) all tools we use to build, because not every tool grants you these permissions.
(Reporter)

Comment 2

11 months ago
I was actually referring to the Windows SDKs.  Iif I install all of the build requirements for windows specified on the build requirements page and update everything to latest version via the update tools, I could not compile while bug 1337331 was on the tree.  Yet for some reason things worked in automation.  Trying to figure out what is different and how do I get to be running the same SDKs as are in automation.
(Reporter)

Updated

11 months ago
Blocks: 1337331
Summary: Windows builds appear to be using tools not provided to developers → Windows automation builds appear to be using different versions of Windows SDKs than you get by installing the specified build pre-requisites.

Updated

8 months ago
Severity: major → normal
Priority: -- → P5
Hi Bill,

I think that the issue of the Win10 SDK not getting picked up has been fixed by bug 1318143, would you mind retesting to see if the Win10 SDK gets picked up automatically for you now (I've tried a build on a VM from scratch and it worked).
You'll need Win10 SDK 10.0.10586.0 or later.

If you edit security/sandbox/chromium/sandbox/win/src/process_mitigations.cc and remove the |#if !defined(MOZ_SANDBOX)| I put around the code that was causing us issues, it should fail to compile without the Win10 SDK.

I had to clobber build to get it work after installing the SDK.
Thanks.
Flags: needinfo?(wgianopoulos)
(Reporter)

Comment 4

7 months ago
(In reply to Bob Owen (:bobowen) from comment #3)
> Hi Bill,
> 
> I think that the issue of the Win10 SDK not getting picked up has been fixed
> by bug 1318143, would you mind retesting to see if the Win10 SDK gets picked
> up automatically for you now (I've tried a build on a VM from scratch and it
> worked).
> You'll need Win10 SDK 10.0.10586.0 or later.
> 
> If you edit security/sandbox/chromium/sandbox/win/src/process_mitigations.cc
> and remove the |#if !defined(MOZ_SANDBOX)| I put around the code that was
> causing us issues, it should fail to compile without the Win10 SDK.
> 
> I had to clobber build to get it work after installing the SDK.
> Thanks.

My A/C unit at home is not functioning so I can;t run my Windows build system to test this.  I might have some info later this week.
(Reporter)

Comment 5

7 months ago
I am trying to set up a build system on one of my laptops.  I should have an answer for you soon.
Flags: needinfo?(wgianopoulos)
(Reporter)

Comment 6

7 months ago
I finally got Windows to build on this laptop.  I can verify that the issue has been resolved.
(In reply to Bill Gianopoulos [:WG9s] from comment #6)
> I finally got Windows to build on this laptop.  I can verify that the issue
> has been resolved.

That's great, thanks Bill.

Even though this bug's title is about a slightly different thing, I think the main issue was that a standard build didn't pick up the Win10 SDK properly, which automation (and hacked local builds) did.

So, I'm going to mark this as resolved.

In bug 1380609, we want to make the Win10 SDK required for building (at least v10.0.10586.0, but possibly v10.0.14393.0).
My experiments seemed to show this worked, but I wanted to make sure you, as someone else who'd hit this issue, could also build.
Status: NEW → RESOLVED
Last Resolved: 7 months ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.