Closed
Bug 1350624
Opened 7 years ago
Closed 7 years ago
Adjust *_EVENT_RECEIVED_MS telemetry probes
Categories
(Toolkit :: Performance Monitoring, enhancement)
Toolkit
Performance Monitoring
Tracking
()
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: Harald, Assigned: wcpan)
References
Details
Attachments
(1 file)
Data data so far shows that most events are handled within one frame, great! We just need some adjustments: 1) rename to EVENT_RECEIVED_*_MS for more coherent naming like other probes 2) Cap high for all histograms at 5.000, not 50.000 3) Remove MOUSE_MOVE_EVENT_RECEIVED_MS, it mostly fires immediately and I'd rather not slow it down with telemetry if we don't use it.
Reporter | ||
Updated•7 years ago
|
Flags: needinfo?(wpan)
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → wpan
Flags: needinfo?(wpan)
Assignee | ||
Comment 1•7 years ago
|
||
I'm going to rename these probes to * DISPATCHER_RECEIVED_CLICK_MS * DISPATCHER_RECEIVED_KEYBOARD_MS * DISPATCHER_RECEIVED_APZ_HANDLED_TOUCH_MOVE_MS * DISPATCHER_RECEIVED_APZ_HANDLED_MOUSE_MOVE_MS * DISPATCHER_RECEIVED_APZ_HANDLED_WHEEL_MS How would you feel about this?
Flags: needinfo?(hkirschner)
Reporter | ||
Comment 2•7 years ago
|
||
Capturing the result from a quick offline chat with :wcpan. To make this fit into existing probes, we'll go with: INPUT_EVENT_QUEUED_CLICK_MS INPUT_EVENT_QUEUED_KEYBOARD_MS INPUT_EVENT_QUEUED_APZ_TOUCH_MOVE_MS INPUT_EVENT_QUEUED_APZ_MOUSE_MOVE_MS INPUT_EVENT_QUEUED_APZ_WHEEL_MS
Flags: needinfo?(hkirschner)
Comment hidden (mozreview-request) |
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8853565 [details] Bug 1350624 - Adjust *_EVENT_RECEIVED_MS telemetry probes. https://reviewboard.mozilla.org/r/125622/#review128228 lgtm
Attachment #8853565 -
Flags: review?(michael) → review+
Assignee | ||
Comment 5•7 years ago
|
||
Thanks!
Pushed by wpan@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d52b06db14ec Adjust *_EVENT_RECEIVED_MS telemetry probes. r=mystor
Comment 7•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/d52b06db14ec
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Assignee | ||
Comment 8•7 years ago
|
||
:bsmedberg, I'm sorry that I forgot to request for data review. Could you review these probes? (which was added in bug 1341531, and renamed in this bug) If there is any problem, I'll file another bug to fix it. Thank you.
Flags: needinfo?(benjamin)
You need to log in
before you can comment on or make changes to this bug.
Description
•