Closed Bug 1350641 Opened 3 years ago Closed 3 years ago

Allow MOZ_DEBUG_CHILD_PAUSE to specify the child process startup sleep time [MOZ_DEBUG_CHILD_PROCESS]

Categories

(Firefox :: General, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
Firefox 55
Tracking Status
firefox55 --- fixed

People

(Reporter: jwatt, Assigned: jwatt)

Details

Attachments

(2 files)

I find the MOZ_DEBUG_CHILD_PROCESS/MOZ_DEBUG_CHILD_PAUSE sleep behavior a bit annoying. Too long on Mac, not long enough on Windows. Let's allow MOZ_DEBUG_CHILD_PAUSE to actually specify the sleep duration in seconds.
Attached patch patchSplinter Review
Assignee: nobody → jwatt
Attachment #8851300 - Flags: review?(jmathies)
I also noticed that when MOZ_DEBUG_CHILD_PAUSE was introduced we didn't fix up MessageChannel::ShouldContinueFromTimeout to check for that in addition to MOZ_DEBUG_CHILD_PROCESS.
Attachment #8851349 - Flags: review?(jmathies)
Attachment #8851300 - Flags: review?(jmathies) → review+
Attachment #8851349 - Flags: review?(jmathies) → review+
Pushed by jwatt@jwatt.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f474083089c3
Allow MOZ_DEBUG_CHILD_PAUSE to specify the child process startup sleep time. r=jimm
https://hg.mozilla.org/integration/mozilla-inbound/rev/3857cc2ac3f5
Fix MessageChannel::ShouldContinueFromTimeout to check MOZ_DEBUG_CHILD_PAUSE. r=jimm
https://hg.mozilla.org/mozilla-central/rev/f474083089c3
https://hg.mozilla.org/mozilla-central/rev/3857cc2ac3f5
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
You need to log in before you can comment on or make changes to this bug.