1350666 - Android RefPtr.h/AudioContext.h build bustage when Gecko 54 merges to beta on 2017-04-17

Status: RESOLVED FIXED

(Core :: Web Audio, defect, P1)

Description

[Phil Ringnalda (:philor)]

e.g. https://treeherder.mozilla.org/logviewer.html#?job_id=86476887&repo=try from https://treeherder.mozilla.org/#/jobs?repo=try&revision=22dcba38b9bb5708374b8af5169685e46e9dd674&selectedJob=86476887

INFO -  In file included from /home/worker/workspace/build/src/obj-firefox/dist/include/nsISupportsUtils.h:15:0,
INFO -                   from /home/worker/workspace/build/src/obj-firefox/dist/include/nsISupportsImpl.h:14,
INFO -                   from /home/worker/workspace/build/src/obj-firefox/dist/include/mozilla/dom/NonRefcountedDOMObject.h:10,
INFO -                   from /home/worker/workspace/build/src/obj-firefox/dom/bindings/SVGUnitTypeValuesBinding.cpp:3,
INFO -                   from /home/worker/workspace/build/src/obj-firefox/dom/bindings/UnifiedBindings18.cpp:2:
INFO -  /home/worker/workspace/build/src/obj-firefox/dist/include/mozilla/RefPtr.h: In instantiation of 'static void mozilla::RefPtrTraits<U>::Release(U*) [with U = mozilla::DOMMediaStream]':
INFO -  /home/worker/workspace/build/src/obj-firefox/dist/include/mozilla/RefPtr.h:394:45:   required from 'static void RefPtr<T>::ConstRemovingRefPtrTraits<U>::Release(U*) [with U = mozilla::DOMMediaStream; T = mozilla::DOMMediaStream]'
INFO -  /home/worker/workspace/build/src/obj-firefox/dist/include/mozilla/RefPtr.h:78:52:   required from 'RefPtr<T>::~RefPtr() [with T = mozilla::DOMMediaStream]'
INFO -  /home/worker/workspace/build/src/obj-firefox/dist/include/mozilla/dom/SpeechRecognition.h:133:32:   required from here
INFO -  /home/worker/workspace/build/src/obj-firefox/dist/include/mozilla/RefPtr.h:40:5: error: invalid use of incomplete type 'class mozilla::DOMMediaStream'
INFO -       aPtr->Release();
INFO -       ^
INFO -  In file included from /home/worker/workspace/build/src/obj-firefox/dist/include/mozilla/dom/AudioNode.h:14:0,
INFO -                   from /home/worker/workspace/build/src/obj-firefox/dist/include/mozilla/dom/ScriptProcessorNode.h:10,
INFO -                   from /home/worker/workspace/build/src/obj-firefox/dom/bindings/ScriptProcessorNodeBinding.cpp:14,
INFO -                   from /home/worker/workspace/build/src/obj-firefox/dom/bindings/UnifiedBindings18.cpp:110:
INFO -  /home/worker/workspace/build/src/obj-firefox/dist/include/mozilla/dom/AudioContext.h:38:7: error: forward declaration of 'class mozilla::DOMMediaStream'
INFO -   class DOMMediaStream;
INFO -         ^
INFO -  /home/worker/workspace/build/src/config/rules.mk:1016: recipe for target 'UnifiedBindings18.o' failed
INFO -  gmake[5]: *** [UnifiedBindings18.o] Error 1

Beyond my understanding, but https://hg.mozilla.org/releases/mozilla-aurora/log/997b98cce1aebf76641e14c79ac250cdb147041c/dom/media/webaudio/AudioContext.h says maybe ehsan or edgar will know what that means.

Comment 1

[Phil Ringnalda (:philor)]

[Tracking Requested - why for this release]: merge build bustage, closed tree, sadness.

Comment 2

[Paul Adenot (:padenot)]

Looks like we need the patch in bug 1345771.

Comment 3

[Paul Adenot (:padenot)]

We've uplifted the (very simple) patch to the right branch, in bug 1345771, closing this.

Comment 4

[Gerry Chang [:gchang]]

Track 54- as it's fixed in bug 1345771.