Closed
Bug 1350703
Opened 7 years ago
Closed 7 years ago
Typos in layout/XUL sources
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: paul.bignier, Assigned: paul.bignier)
Details
Attachments
(1 file)
|
1.29 KB,
patch
|
dholbert
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Firefox/52.0 Build ID: 20170316213829 Steps to reproduce: Simple typos fix in the comments
|
Assignee | |
Comment 1•7 years ago
|
||
|
|
Assignee | |
Comment 2•7 years ago
|
||
Not sure who to set as reviewer though :/ Or even in which component to file it as I can't find Layout nor XUL. Regards, Paul
|
||
Updated•7 years ago
|
Attachment #8851369 -
Flags: review?(dholbert)
|
|
||
Updated•7 years ago
|
Component: Untriaged → ImageLib
Product: Firefox → Core
|
||
Updated•7 years ago
|
Assignee: nobody → paul.bignier
Component: ImageLib → Layout: Misc Code
|
||
Comment 3•7 years ago
|
||
Comment on attachment 8851369 [details] [diff] [review] Typo fixes in layout/XUL Review of attachment 8851369 [details] [diff] [review]: ----------------------------------------------------------------- Thanks for the fix! r=me Note: in the future, for comment-only changes, you can & probably should include an extra line in your commit message that looks like: > DONTBUILD because comment-only ...or something like that. And then if your patch happens to be pushed in an entirely-DONTBUILD push (which is unlikely if it's bundled with other stuff by sheriffs, but will trivially happen if it lands on its own), we won't trigger any builds/tests for it, which is good. Anyway, in this case I'll add r=dholbert & "DONTBUILD" to the commit message and land this, because it's easy and I'm already here. :)
Attachment #8851369 -
Flags: review?(dholbert) → review+
Pushed by dholbert@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/b94b13d756c1 Typo fixes in code-comments within layout/XUL. r=dholbert
|
|
||
Updated•7 years ago
|
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/b94b13d756c1
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
|
||
Updated•6 years ago
|
Product: Core → Core Graveyard
|
||
Updated•6 years ago
|
Component: Layout: Misc Code → Layout
Product: Core Graveyard → Core
You need to log in
before you can comment on or make changes to this bug.
Description
•