Closed Bug 1350719 Opened 3 years ago Closed 3 years ago

0rtt indicator

Categories

(Core :: Networking: HTTP, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: mcmanus, Assigned: mcmanus)

Details

(Whiteboard: [necko-active])

Attachments

(2 files, 2 obsolete files)

Attached image 0rrtindicator.PNG
when we send early (0rtt) data it would be good to expose that in devtools.

for starters I'll inject a response header, as we did with spdy, if devtools would like to build something richer from that, it would be ok.

x-firefox-early-data: {sent, accepted}
Attachment #8851383 - Flags: review?(dd.mozilla)
Assignee: nobody → mcmanus
Status: NEW → ASSIGNED
Attachment #8851391 - Flags: review?(dd.mozilla)
Attachment #8851383 - Attachment is obsolete: true
Attachment #8851383 - Flags: review?(dd.mozilla)
Whiteboard: [necko-active]
Comment on attachment 8851391 [details] [diff] [review]
injected http response header 0rtt

Review of attachment 8851391 [details] [diff] [review]:
-----------------------------------------------------------------

::: netwerk/protocol/http/nsHttpTransaction.cpp
@@ +2166,5 @@
>  {
>     if (mRequestHead->IsSafeMethod() &&
>         !mConnection->IsProxyConnectInProgress()) {
>       m0RTTInProgress = true;
> +     mEarlyDataDisposition = EARLY_SENT;

You should move this where we really write data to the network, to be sure that we actually have sent something.

@@ +2180,5 @@
>      m0RTTInProgress = false;
> +    if (!aRestart) {
> +        // note that if this is invoked by a 3 param version of finish0rtt this
> +        // disposition might be reverted
> +        mEarlyDataDisposition = EARLY_ACCEPTED;

If you change the part from the comment above you should check if mEarlyDataDisposition == EARLY_SENT here.
Attachment #8851391 - Flags: review?(dd.mozilla)
Attachment #8852009 - Flags: review?(dd.mozilla)
Attachment #8851391 - Attachment is obsolete: true
Attachment #8852009 - Flags: review?(dd.mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/09e0d7c1d27a
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.