Closed Bug 1350752 Opened 3 years ago Closed 3 years ago

Cleanup of callback lifetime management in mozStorage

Categories

(Toolkit :: Storage, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: jesup, Assigned: jesup)

References

Details

Attachments

(1 file)

The lifetime management for callbacks in async Storage operations is overly manual, and prone to errors.  It should be cleaned up.
Attachment #8851413 - Flags: review?(michael)
Comment on attachment 8851413 [details] [diff] [review]
Cleanup async mozStorage callback management r=?

Review of attachment 8851413 [details] [diff] [review]:
-----------------------------------------------------------------

This is much nicer than the old code, thanks!
Attachment #8851413 - Flags: review?(michael) → review+
Pushed by rjesup@wgate.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9fd2650f5db0
Cleanup async mozStorage callback management r=layzell
https://hg.mozilla.org/mozilla-central/rev/9fd2650f5db0
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Component: DOM: IndexedDB → Storage
Product: Core → Toolkit
Blocks: 1375217
You need to log in before you can comment on or make changes to this bug.