Closed
Bug 1350792
Opened 7 years ago
Closed 7 years ago
Add fuzzy for mask related reftests when enabling advanced layer
Categories
(Core :: Graphics: WebRender, enhancement)
Core
Graphics: WebRender
Tracking
()
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: ethlin, Assigned: ethlin)
References
Details
(Keywords: correctness)
Attachments
(1 file, 1 obsolete file)
7.74 KB,
patch
|
mchang
:
review+
|
Details | Diff | Splinter Review |
I checked the R7 result[1] with 'layers.advanced.border-layers' on. All failures are due to the edge error. I think we should just add fuzzy-if for these tests. [1] https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://queue.taskcluster.net/v1/task/WbUCtXJwT-qdXukxWTCLFg/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1
Assignee | ||
Updated•7 years ago
|
Summary: Add fuzzy for R7 reftests using WR border layer → Add fuzzy for R7 reftests when using WR border layer
Assignee | ||
Comment 1•7 years ago
|
||
Attachment #8851482 -
Flags: review?(mchang)
Comment 2•7 years ago
|
||
(In reply to Ethan Lin[:ethlin] from comment #0) > I checked the R7 result[1] with 'layers.advanced.border-layers' on. All > failures are due to the edge error. I think we should just add fuzzy-if for > these tests. > > [1] > https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/ > reftest-analyzer.xhtml#logurl=https://queue.taskcluster.net/v1/task/ > WbUCtXJwT-qdXukxWTCLFg/runs/0/artifacts/public/logs/live_backing. > log&only_show_unexpected=1 None of these are currently marked fuzzy on any platform. Do you know why these are failing? What do you mean by edge error?
Flags: needinfo?(ethlin)
Assignee | ||
Comment 3•7 years ago
|
||
(In reply to Mason Chang [:mchang] from comment #2) > (In reply to Ethan Lin[:ethlin] from comment #0) > > I checked the R7 result[1] with 'layers.advanced.border-layers' on. All > > failures are due to the edge error. I think we should just add fuzzy-if for > > these tests. > > > > [1] > > https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/ > > reftest-analyzer.xhtml#logurl=https://queue.taskcluster.net/v1/task/ > > WbUCtXJwT-qdXukxWTCLFg/runs/0/artifacts/public/logs/live_backing. > > log&only_show_unexpected=1 > > None of these are currently marked fuzzy on any platform. Do you know why > these are failing? What do you mean by edge error? I mean there are some errors on the edge of the layer. I think that's because originally we render these items in PaintedLayer and now we compose these layers in WR. I'll study more deeply for this case since there are many this kind failures in other reftest chunks.
Flags: needinfo?(ethlin)
Assignee | ||
Updated•7 years ago
|
Attachment #8851482 -
Flags: review?(mchang)
Comment 4•7 years ago
|
||
> I mean there are some errors on the edge of the layer. I think that's because originally we render these items in PaintedLayer and now we compose these layers in WR.
I've noticed the same sort of thing when switching nsDisplaySolidColor to be a layer. I think this is expected since the gpu is now compositing two layers rather than the cpu rasterizing one. I think fuzzing is correct if it's just round the edges and minor differences.
Updated•7 years ago
|
Keywords: correctness
Assignee | ||
Updated•7 years ago
|
Summary: Add fuzzy for R7 reftests when using WR border layer → Add fuzzy for mask related reftests when enabling advanced layer
Assignee | ||
Comment 5•7 years ago
|
||
I did some more investigation when I looked into reftest failures of background color layer[1] (R7). Originally we used painted layer to paint everything. After setting layer state to active, we'll inevitably create a mask layer for the active layer. As Jamie said in comment4, gpu is now compositing two layers rather than the cpu rasterizing one. I think fuzzy should be correct way to fix it. [1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=991845a10fc6c6ab1049b89580242b340c223cd8&selectedJob=90755906
Assignee | ||
Comment 6•7 years ago
|
||
Attachment #8859913 -
Flags: review?(mchang)
Assignee | ||
Updated•7 years ago
|
Attachment #8851482 -
Attachment is obsolete: true
Updated•7 years ago
|
Attachment #8859913 -
Flags: review?(mchang) → review+
Assignee | ||
Comment 7•7 years ago
|
||
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ec92a6b7d00799f2b4ccd77154ede404d54a0f9c
Pushed by ethlin@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/26697002542a Add fuzzy-if for some svg and mask related reftest when turning on background color layer. r=mchang
Comment 9•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/26697002542a
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•