Add fuzzy for mask related reftests when enabling advanced layer

RESOLVED FIXED in Firefox 55

Status

()

Core
Graphics: WebRender
RESOLVED FIXED
8 months ago
6 months ago

People

(Reporter: ethlin, Assigned: ethlin)

Tracking

({correctness})

unspecified
mozilla55
correctness
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

8 months ago
I checked the R7 result[1] with 'layers.advanced.border-layers' on. All failures are due to the edge error. I think we should just add fuzzy-if for these tests.

[1] https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://queue.taskcluster.net/v1/task/WbUCtXJwT-qdXukxWTCLFg/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1
(Assignee)

Updated

8 months ago
Summary: Add fuzzy for R7 reftests using WR border layer → Add fuzzy for R7 reftests when using WR border layer
(Assignee)

Comment 1

8 months ago
Created attachment 8851482 [details] [diff] [review]
add fuzzy
Attachment #8851482 - Flags: review?(mchang)
(In reply to Ethan Lin[:ethlin] from comment #0)
> I checked the R7 result[1] with 'layers.advanced.border-layers' on. All
> failures are due to the edge error. I think we should just add fuzzy-if for
> these tests.
> 
> [1]
> https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/
> reftest-analyzer.xhtml#logurl=https://queue.taskcluster.net/v1/task/
> WbUCtXJwT-qdXukxWTCLFg/runs/0/artifacts/public/logs/live_backing.
> log&only_show_unexpected=1

None of these are currently marked fuzzy on any platform. Do you know why these are failing? What do you mean by edge error?
Flags: needinfo?(ethlin)
(Assignee)

Comment 3

8 months ago
(In reply to Mason Chang [:mchang] from comment #2)
> (In reply to Ethan Lin[:ethlin] from comment #0)
> > I checked the R7 result[1] with 'layers.advanced.border-layers' on. All
> > failures are due to the edge error. I think we should just add fuzzy-if for
> > these tests.
> > 
> > [1]
> > https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/
> > reftest-analyzer.xhtml#logurl=https://queue.taskcluster.net/v1/task/
> > WbUCtXJwT-qdXukxWTCLFg/runs/0/artifacts/public/logs/live_backing.
> > log&only_show_unexpected=1
> 
> None of these are currently marked fuzzy on any platform. Do you know why
> these are failing? What do you mean by edge error?

I mean there are some errors on the edge of the layer. I think that's because originally we render these items in PaintedLayer and now we compose these layers in WR. I'll study more deeply for this case since there are many this kind failures in other reftest chunks.
Flags: needinfo?(ethlin)
(Assignee)

Updated

8 months ago
Attachment #8851482 - Flags: review?(mchang)

Comment 4

8 months ago
> I mean there are some errors on the edge of the layer. I think that's because originally we render these items in PaintedLayer and now we compose these layers in WR.

I've noticed the same sort of thing when switching nsDisplaySolidColor to be a layer. I think this is expected since the gpu is now compositing two layers rather than the cpu rasterizing one. I think fuzzing is correct if it's just round the edges and minor differences.

Updated

8 months ago
Keywords: correctness
(Assignee)

Updated

7 months ago
Summary: Add fuzzy for R7 reftests when using WR border layer → Add fuzzy for mask related reftests when enabling advanced layer
(Assignee)

Comment 5

7 months ago
I did some more investigation when I looked into reftest failures of background color layer[1] (R7). Originally we used painted layer to paint everything. After setting layer state to active, we'll inevitably create a mask layer for the active layer. As Jamie said in comment4, gpu is now compositing two layers rather than the cpu rasterizing one. I think fuzzy should be correct way to fix it.


[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=991845a10fc6c6ab1049b89580242b340c223cd8&selectedJob=90755906
(Assignee)

Comment 6

7 months ago
Created attachment 8859913 [details] [diff] [review]
add fuzzy for mask related reftests
Attachment #8859913 - Flags: review?(mchang)
(Assignee)

Updated

7 months ago
Attachment #8851482 - Attachment is obsolete: true
(Assignee)

Updated

7 months ago
Blocks: 1358055
Attachment #8859913 - Flags: review?(mchang) → review+
(Assignee)

Comment 7

6 months ago
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ec92a6b7d00799f2b4ccd77154ede404d54a0f9c

Comment 8

6 months ago
Pushed by ethlin@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/26697002542a
Add fuzzy-if for some svg and mask related reftest when turning on background color layer. r=mchang
https://hg.mozilla.org/mozilla-central/rev/26697002542a
Status: NEW → RESOLVED
Last Resolved: 6 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.