Crash when VRDisplayHost::SubmitFrame()

RESOLVED FIXED in Firefox 55

Status

()

Core
WebVR
RESOLVED FIXED
8 months ago
8 months ago

People

(Reporter: daoshengmu, Assigned: kip)

Tracking

unspecified
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

8 months ago
It's happened when calling VRDisplayHost::SubmitFrame(), and the texture from IPC has a nullptr in mTextureHost. Then, calling AutoLockTextureHostWithoutCompositor would have an assertion.
(Reporter)

Comment 1

8 months ago
It should can be caught by our existing vr tests. Interesting to how it passes the test...
(Assignee)

Comment 2

8 months ago
This seems to have been regressed by Bug 1343814.  MozRegression points to a commit:

https://hg.mozilla.org/integration/mozilla-inbound/rev/64c73abd4190
(Assignee)

Updated

8 months ago
Assignee: nobody → kgilbert
(Assignee)

Comment 3

8 months ago
Getting Closer...  An earlier patch in the same bug may be responsible for the crash:

https://hg.mozilla.org/integration/mozilla-inbound/rev/d55f871c503d

------------

 RefPtr<ID3D11Device>
 DXGITextureHostD3D11::GetDevice()
 {
   if (mFlags & TextureFlags::INVALID_COMPOSITOR) {
     return nullptr;
   }
 
-  return DeviceManagerDx::Get()->GetCompositorDevice();
+  return mProvider->GetD3D11Device();
 }
(Assignee)

Updated

8 months ago
Blocks: 1350247
(Assignee)

Updated

8 months ago
No longer blocks: 1350247
Depends on: 1350247
Comment hidden (mozreview-request)
(Assignee)

Updated

8 months ago
Attachment #8851774 - Flags: review?(dvander)

Comment 5

8 months ago
mozreview-review
Comment on attachment 8851774 [details]
Bug 1350794 - Avoid dereferencing aProvider when null in DataTextureSourceD3D11 constructor

https://reviewboard.mozilla.org/r/124002/#review126524
Attachment #8851774 - Flags: review?(dvander) → review+

Comment 6

8 months ago
Pushed by kgilbert@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/71dcc186d4f6
Avoid dereferencing aProvider when null in DataTextureSourceD3D11 constructor r=dvander

Comment 7

8 months ago
I had to back this out in https://hg.mozilla.org/integration/autoland/rev/3c201a39f5df for bustage:

https://treeherder.mozilla.org/logviewer.html#?job_id=86765716&repo=autoland
Flags: needinfo?(kgilbert)

Comment 8

8 months ago
Pushed by kgilbert@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/16602c79bce6
Avoid dereferencing aProvider when null in DataTextureSourceD3D11 constructor
(Assignee)

Comment 9

8 months ago
(In reply to Wes Kocher (:KWierso) from comment #7)
> I had to back this out in
> https://hg.mozilla.org/integration/autoland/rev/3c201a39f5df for bustage:
> 
> https://treeherder.mozilla.org/logviewer.html#?job_id=86765716&repo=autoland

I suspect the issue was that the dependent patch (which added mDevice) was in mozilla-inbound, while this one was in autoland.

I've pushed to mozilla-inbound in hopes that they will land in the right order now.
Flags: needinfo?(kgilbert)

Comment 10

8 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/16602c79bce6
Status: NEW → RESOLVED
Last Resolved: 8 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
(Assignee)

Updated

8 months ago
Duplicate of this bug: 1351017
You need to log in before you can comment on or make changes to this bug.