1350794 - Crash when VRDisplayHost::SubmitFrame()

Status: RESOLVED FIXED

(Core :: WebVR, defect)

Description

[Daosheng Mu[:daoshengmu]]

It's happened when calling VRDisplayHost::SubmitFrame(), and the texture from IPC has a nullptr in mTextureHost. Then, calling AutoLockTextureHostWithoutCompositor would have an assertion.

Comment 1

[Daosheng Mu[:daoshengmu]]

It should can be caught by our existing vr tests. Interesting to how it passes the test...

Comment 2

[:kip (Kearwood Gilbert)]

This seems to have been regressed by Bug 1343814.  MozRegression points to a commit:

https://hg.mozilla.org/integration/mozilla-inbound/rev/64c73abd4190

Comment 3

[:kip (Kearwood Gilbert)]

Getting Closer...  An earlier patch in the same bug may be responsible for the crash:

https://hg.mozilla.org/integration/mozilla-inbound/rev/d55f871c503d

------------

 RefPtr<ID3D11Device>
 DXGITextureHostD3D11::GetDevice()
 {
   if (mFlags & TextureFlags::INVALID_COMPOSITOR) {
     return nullptr;
   }
 
-  return DeviceManagerDx::Get()->GetCompositorDevice();
+  return mProvider->GetD3D11Device();
 }

Comment 4

[:kip (Kearwood Gilbert)]

Attachment: Bug 1350794 - Avoid dereferencing aProvider when null in DataTextureSourceD3D11 constructor

- Require bug 1350247 patch to land first to fix WebVR crash

Review commit: https://reviewboard.mozilla.org/r/124002/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/124002/

Comment 5

[David Anderson [:dvander] - inactive, e-mail if emergency]

Comment on attachment 8851774 [details]
Bug 1350794 - Avoid dereferencing aProvider when null in DataTextureSourceD3D11 constructor

https://reviewboard.mozilla.org/r/124002/#review126524

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/71dcc186d4f6
Avoid dereferencing aProvider when null in DataTextureSourceD3D11 constructor r=dvander

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I had to back this out in https://hg.mozilla.org/integration/autoland/rev/3c201a39f5df for bustage:

https://treeherder.mozilla.org/logviewer.html#?job_id=86765716&repo=autoland

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/16602c79bce6
Avoid dereferencing aProvider when null in DataTextureSourceD3D11 constructor

Comment 9

[:kip (Kearwood Gilbert)]

(In reply to Wes Kocher (:KWierso) from comment #7)
> I had to back this out in
> https://hg.mozilla.org/integration/autoland/rev/3c201a39f5df for bustage:
> 
> https://treeherder.mozilla.org/logviewer.html#?job_id=86765716&repo=autoland

I suspect the issue was that the dependent patch (which added mDevice) was in mozilla-inbound, while this one was in autoland.

I've pushed to mozilla-inbound in hopes that they will land in the right order now.

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/16602c79bce6