1350821 - [webvtt] subtitle disappear with the ui control.

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P1)

Description

[Benjamin Chen [:bechen]]

Latest nightly,
str:
1. play a video with webvtt subtitle
2. press mouse right key -> hide ui control
subtitle disappeared.

Comment 1

[Benjamin Chen [:bechen]]

The show/hide control seems trigger nsVideoFrame::CreateAnonymousContent again.

Comment 2

[Ray Lin[:ralin]]

I'm not sure but if so, I guess after video frame re-constructed, webvtt lost the reference to new ".caption-div" therefore we could not update the caption anymore.

Comment 3

[Ray Lin[:ralin]]

perhaps we can dispatch and carry new reference to webvtt.jsm via event in nsVideoFrame::CreateAnonymousContent?

Comment 4

[Benjamin Chen [:bechen]]

(In reply to Ray Lin[:ralin] from comment #3)
> perhaps we can dispatch and carry new reference to webvtt.jsm via event in
> nsVideoFrame::CreateAnonymousContent?

Right, I'm going to write a function like nsVideoFrame::HasVideoElement() to notify the mediaElement to render the subtitle.

Comment 5

[Benjamin Chen [:bechen]]

Attachment: Bug 1350821 - Notify the mediaElement to render subtitle when the mCaption was created or re-created.

Review commit: https://reviewboard.mozilla.org/r/124186/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/124186/

Comment 6

[Ralph Giles (:rillian)]

Comment on attachment 8851931 [details]
Bug 1350821 - Notify the mediaElement to render subtitle when the mCaption was created or re-created.

https://reviewboard.mozilla.org/r/124186/#review126994

Would be nice if we could add a test for this. I don't know how to do user-interaction tests. Marionette, I think?

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4d31fef17298
Notify the mediaElement to render subtitle when the mCaption was created or re-created. r=rillian

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4d31fef17298

Comment 9

[Blake Wu [:bwu][:blakewu]]

Benjamin, 
Does this affect 54 as well? If yes, we may need to request a uplift.

Comment 10

[Benjamin Chen [:bechen]]

(In reply to Blake Wu [:bwu][:blakewu] from comment #9)
> Benjamin, 
> Does this affect 54 as well? If yes, we may need to request a uplift.

Not sure, but I guess the bug also exist in FF54.
I don't think it should uplift to 54 because it is just a UI bug. Real user barely hit this one,
and even the bug occurs, after press play button, subtitle works again.