Change the type of LOW_AUDIO_USECS to TimeUnit in MDSM

RESOLVED FIXED in Firefox 55

Status

()

Core
Audio/Video: Playback
P3
normal
RESOLVED FIXED
7 months ago
7 months ago

People

(Reporter: jwwang, Assigned: jwwang)

Tracking

(Blocks: 1 bug)

unspecified
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(3 attachments)

Comment hidden (empty)
(Assignee)

Updated

7 months ago
Assignee: nobody → jwwang
Blocks: 1245019
Priority: -- → P3
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Updated

7 months ago
Attachment #8852302 - Flags: review?(kikuo)
Attachment #8852303 - Flags: review?(kikuo)
Attachment #8852304 - Flags: review?(kikuo)

Comment 4

7 months ago
mozreview-review
Comment on attachment 8852302 [details]
Bug 1350832. P1 - change the type of LOW_AUDIO_USECS to TimeUnit.

https://reviewboard.mozilla.org/r/124548/#review127844
Attachment #8852302 - Flags: review?(kikuo) → review+

Comment 5

7 months ago
mozreview-review
Comment on attachment 8852303 [details]
Bug 1350832. P2 - change the type of mLowAudioThresholdUsecs to TimeUnit.

https://reviewboard.mozilla.org/r/124550/#review127856
Attachment #8852303 - Flags: review?(kikuo) → review+

Comment 6

7 months ago
mozreview-review
Comment on attachment 8852304 [details]
Bug 1350832. P3 - rename variables and fix comments.

https://reviewboard.mozilla.org/r/124552/#review127858

::: dom/media/MediaDecoderStateMachine.h:593
(Diff revision 1)
> -  // pause decoding. If we increase mLowAudioThresholdUsecs, we'll also
> -  // increase this too appropriately (we don't want mLowAudioThresholdUsecs
> +  // pause decoding. If we increase mLowAudioThreshold, we'll also
> +  // increase this too appropriately (we don't want mLowAudioThreshold
>    // to be greater than ampleAudioThreshold, else we'd stop decoding!).
>    // Note that we don't ever reset this threshold, it only ever grows as
>    // we detect that the decode can't keep up with rendering.
>    int64_t mAmpleAudioThresholdUsecs;

Any plan to file a bug to replace this too ?
Attachment #8852304 - Flags: review?(kikuo) → review+
(Assignee)

Comment 7

7 months ago
mozreview-review-reply
Comment on attachment 8852304 [details]
Bug 1350832. P3 - rename variables and fix comments.

https://reviewboard.mozilla.org/r/124552/#review127858

> Any plan to file a bug to replace this too ?

Yes. There is bug 1350837. :)
(Assignee)

Comment 8

7 months ago
Thanks!

Comment 9

7 months ago
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d972b0fcb402
P1 - change the type of LOW_AUDIO_USECS to TimeUnit. r=kikuo
https://hg.mozilla.org/integration/autoland/rev/2533d6d1aa34
P2 - change the type of mLowAudioThresholdUsecs to TimeUnit. r=kikuo
https://hg.mozilla.org/integration/autoland/rev/41344842642b
P3 - rename variables and fix comments. r=kikuo

Comment 10

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d972b0fcb402
https://hg.mozilla.org/mozilla-central/rev/2533d6d1aa34
https://hg.mozilla.org/mozilla-central/rev/41344842642b
Status: NEW → RESOLVED
Last Resolved: 7 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.