1350852 - Dispatch a specific event to cancel the throbber while resuming video decoder.

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement)

Description

[Tzuhao Kuo [:kaku]]

In bug 1309494, we use the "canplay" event to cancel the throbber which was fine, however, in bug 1349097, we're going to resume a video decoder after the playback had ended, and this is not going to work because we won't dispatch the "canplay" anymore after the playback had ended.

So, we need a rather specific event for canceling the throbber.

Comment 1

[Tzuhao Kuo [:kaku]]

Attachment: Bug 1350852 P1 - add a mozvideoonlyseekcompleted event;

Review commit: https://reviewboard.mozilla.org/r/124074/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/124074/

Comment 2

[Tzuhao Kuo [:kaku]]

Attachment: Bug 1350852 P2 - use mozvideoonlyseekcompleted to cancel throbber while resuming video decoder;

Review commit: https://reviewboard.mozilla.org/r/124076/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/124076/

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8851899 [details]
Bug 1350852 P1 - add a mozvideoonlyseekcompleted event;

https://reviewboard.mozilla.org/r/124074/#review126648

::: dom/media/MediaDecoderStateMachine.cpp:2402
(Diff revision 1)
>      // and fail the assertion in GetClock() since we didn't stop MediaSink.
>      mMaster->UpdatePlaybackPositionInternal(newCurrentTime);
>    }
>  
> +  // Dispatch a VideoOnlySeekCompleted event to notify JS video controller to
> +  // cancel the throbber UI.

I want a neutral comment here without MDSM understanding the details of the video control. So you might want to say "dispatch an event so the UI can change in response to the end of video-only seek".

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8851900 [details]
Bug 1350852 P2 - use mozvideoonlyseekcompleted to cancel throbber while resuming video decoder;

https://reviewboard.mozilla.org/r/124076/#review126650

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8851900 [details]
Bug 1350852 P2 - use mozvideoonlyseekcompleted to cancel throbber while resuming video decoder;

https://reviewboard.mozilla.org/r/124076/#review126876

Comment 6

[Tzuhao Kuo [:kaku]]

Comment on attachment 8851899 [details]
Bug 1350852 P1 - add a mozvideoonlyseekcompleted event;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/124074/diff/1-2/

Comment 7

[Tzuhao Kuo [:kaku]]

Comment on attachment 8851900 [details]
Bug 1350852 P2 - use mozvideoonlyseekcompleted to cancel throbber while resuming video decoder;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/124076/diff/1-2/

Comment 8

[Tzuhao Kuo [:kaku]]

Thanks for the review!

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/094dc48011f4
P1 - add a mozvideoonlyseekcompleted event; r=jwwang
https://hg.mozilla.org/integration/autoland/rev/fdb359af3621
P2 - use mozvideoonlyseekcompleted to cancel throbber while resuming video decoder; r=jaws,jwwang

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/094dc48011f4
https://hg.mozilla.org/mozilla-central/rev/fdb359af3621