Remove border and background fallback styling from spinbuttons.css

RESOLVED FIXED in Firefox 55

Status

()

Toolkit
Themes
P1
normal
RESOLVED FIXED
8 months ago
7 months ago

People

(Reporter: dao, Assigned: dao)

Tracking

(Blocks: 1 bug)

Trunk
mozilla55
All
Windows
Points:
---
Dependency tree / graph
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox55 fixed)

Details

(Whiteboard: [photon-visual])

Attachments

(1 attachment)

(Assignee)

Description

8 months ago
+++ This bug was initially created as a clone of Bug #1343196 +++

In toolkit/themes/windows/global/spinbuttons.css, we can remove border and background declarations for elements that also set -moz-appearance, since -moz-appearance causes these borders and backgrounds not to be used anyway.

Effectively this means we can remove all border and background related properties from spinbuttons.css except for this instance:

https://dxr.mozilla.org/mozilla-central/rev/e03e0c60462c775c7558a1dc9d5cf2076c3cd1f9/toolkit/themes/windows/global/spinbuttons.css#25
(Assignee)

Comment 1

8 months ago
Created attachment 8852388 [details] [diff] [review]
patch
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Attachment #8852388 - Flags: review?(nhnt11)
(Assignee)

Updated

8 months ago
Blocks: 1351998

Updated

8 months ago
Whiteboard: [good first bug][lang=css] → [photon] [good first bug] [lang=css]
Attachment #8852388 - Flags: review?(nhnt11) → review+

Comment 2

8 months ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8852fbaee933
Remove border and background fallback styling from spinbuttons.css. r=Nihanth
(Assignee)

Updated

8 months ago
Mentor: dao+bmo@mozilla.com
Keywords: good-first-bug
Whiteboard: [photon] [good first bug] [lang=css] → [photon]

Comment 3

8 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/8852fbaee933
Status: ASSIGNED → RESOLVED
Last Resolved: 8 months ago
status-firefox55: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55

Updated

7 months ago
Iteration: --- → 55.2 - Apr 3
Flags: qe-verify?
Priority: -- → P1
Whiteboard: [photon] → [photon-visual]

Updated

7 months ago
Flags: qe-verify? → qe-verify-
You need to log in before you can comment on or make changes to this bug.