Closed
Bug 1350873
Opened 7 years ago
Closed 7 years ago
Remove border and background fallback styling from spinbuttons.css
Categories
(Toolkit :: Themes, enhancement, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: dao, Assigned: dao)
References
Details
(Whiteboard: [photon-visual])
Attachments
(1 file)
|
2.00 KB,
patch
|
nhnt11
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1343196 +++ In toolkit/themes/windows/global/spinbuttons.css, we can remove border and background declarations for elements that also set -moz-appearance, since -moz-appearance causes these borders and backgrounds not to be used anyway. Effectively this means we can remove all border and background related properties from spinbuttons.css except for this instance: https://dxr.mozilla.org/mozilla-central/rev/e03e0c60462c775c7558a1dc9d5cf2076c3cd1f9/toolkit/themes/windows/global/spinbuttons.css#25
|
Assignee | |
Comment 1•7 years ago
|
||
|
||
Updated•7 years ago
|
Whiteboard: [good first bug][lang=css] → [photon] [good first bug] [lang=css]
|
||
Updated•7 years ago
|
Attachment #8852388 -
Flags: review?(nhnt11) → review+
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/8852fbaee933 Remove border and background fallback styling from spinbuttons.css. r=Nihanth
|
|
Assignee | |
Updated•7 years ago
|
|
||
Comment 3•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/8852fbaee933
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
|
|
||
Updated•7 years ago
|
Iteration: --- → 55.2 - Apr 3
Flags: qe-verify?
Priority: -- → P1
Whiteboard: [photon] → [photon-visual]
|
|
||
Updated•7 years ago
|
Flags: qe-verify? → qe-verify-
You need to log in
before you can comment on or make changes to this bug.
Description
•