135089 - Menulists are truncated

Status: RESOLVED WORKSFORME

(SeaMonkey :: Themes, defect)

Description

[Blake Ross]

In Classic:

In Mail Compose, the two dropdowns in the toolbar are truncated...you can't 
read them.

In both Modern and Classic:

One of the dropdowns in the Mail & Newsgroups > Message Display pref panel is 
truncated.

Comment 1

[Blake Ross]

This is a regression that has to be fixed. The fix should be simple/trivial.

Comment 2

[R.K.Aa.]

see also bug 135229

Comment 3

[Lori Kaplan]

approving nomination. adding [adt2] to indicate breadth of exposure of this bug.
It renders the initial text unusable as a menu label by truncating the text
inappropriately. Easy fix, small risk. 

Comment 4

[Brian Ryner (not reading)]

Charlie, I think this is the bug you were seeing in Composer.  You did verify
that this wasn't caused by my patch for bug 131481, right?

Comment 5

[Charles Manske]

Brian: yes, I did, but it deserves another confirmation. I'll test again soon.

Comment 6

[Charles Manske]

Attachment: patch suggestions

Just some suggested changes. It seems that the padding-left is excessive for 
Modern theme, so these changes really helped in many menulists.
Classic doesn't have these left padding amounts, and still seeems to show 
cropped strings.
I still suspect some basic flaw in menulist width calculations -- maybe we are
not
taking into account the width of the graphic on the right used to open the 
menupopup?

Comment 7

[Charles Manske]

*** Bug 138307 has been marked as a duplicate of this bug. ***

Comment 8

[Charles Manske]

My comments from bug 138307:
The default behavior for calculating the preferred width of a menulist should be 
to fit the longest string in the child menupopup->menuitems without cropping.
The most noticeable case is in Composer, including Message Composer:
The Paragraph Style menulist on the formating toolbar should show "Body Text", 
but not it shows "Body T...".
There are many more examples in Composer dialogs are being cropped, e.g.,
1. Click on the Table button and insert a default table. 
2. Dbl click in a cell to bring up Table Properties dialog
3. In the "Size" group, change the "Height" menulist from "pixels" to "% of
table" the later string will be cropped.
Change "Vertical" alignment menulist from "Top" to "Bottom" and latter will be 
cropped. 
In the Image dialog (click on Image toolbar button):
1. Change to the "Appearance" tab. The alignment menulist shows "At the..."
when it should be "At the Bottom"

I tested the 1.0 branch build and it does NOT show the cropped "Body Text" in 
pargraph menulist on Composer toolbar, but it does show the other examples 
of cropping text in various dialog menulists.

Comment 9

[Charles Manske]

As noted in comment #8, this bug does not appear for the Composer toolbar 
paragraph style menulist on the branch. I applied the patch that fixed bug 131481
to the branch and it did NOT cause the menulist cropping to occur, so that fix
is not part of this problem.

Comment 10

[shliang]

Attachment: patch [Checkin: Comment 24 & 34]

adding 14px padding to menulist menuitems (the amount of padding that used to
be on menu accelerators which were removed from menulists)

Comment 11

[Brian Ryner (not reading)]

Comment on attachment 81542 [details] [diff] [review]
patch
[Checkin: Comment 24 & 34]

good catch.  r=bryner.

Comment 12

[Charles Manske]

Attachment: additional suggestion

I agree that fixing the right padding on menu items is very good.
Could you also still include this change from my previous suggested patch?
The 8 pixel padding on the left of menulist in modern still seems like wasted 
space to me!

Comment 13

[Joe Hewitt (gone)]

Comment on attachment 81542 [details] [diff] [review]
patch
[Checkin: Comment 24 & 34]

sr=hewitt

Comment 14

[shliang]

let's keep the 8px padding on the left for now because it looks nicer. but if 
that's turns out to be a problem with cropping (it should be okay now though) 
we can reduce it later.

Comment 15

[Charles Manske]

I don't think it *does* look nicer! Classic doesn't have it. It looks like wasted
space to me!
Jennifer, Lori, Blake: Any opinion?

Comment 16

[shliang]

just asked lori, she said to use the larger padding

Comment 17

[Blake Ross]

So are we really going to ship with this?  This really needs to get into the
beta, it's embarrassing.

Comment 18

[Blake Ross]

*** Bug 142017 has been marked as a duplicate of this bug. ***

Comment 19

[Charles Manske]

Since this probably won't be in the beta, adding RTM to be sure it's checked in
for final release. Could someone please assign an appropriate milestone?

Comment 20

[Charles Manske]

*** Bug 143789 has been marked as a duplicate of this bug. ***

Comment 21

[Charles Manske]

Getting dups on this already for beta build. This is important to fix for RTM

Comment 22

[Charles Manske]

Sorry, this isn't as critical as bug 131481 (and dup bug 143789), but it is 
a simple and safe UI fix that is very important "polish" and should be fixed for 
RTM.

Comment 23

[Charles Manske]

Comment on attachment 81785 [details] [diff] [review]
additional suggestion

Decision was made to not use  this

Comment 24

[shliang]

fixed in trunk

Comment 25

[Patty Mac]

Verified on windows 2000 (trunk build: 2002-05-21-08-TRUNK)

Comment 26

[Christine Wozniak]

Adding custrtm-; no impact on customization.

Comment 27

[Jaime Rodriguez, Jr.]

Was this a Windows only issue, as it says OS: Windows XP, or is this change
needed cross platform?

Comment 28

[Charles Manske]

This is an XP problem.

Comment 29

[Frank Tang]

*** Bug 148445 has been marked as a duplicate of this bug. ***

Comment 30

[Frank Tang]

this is very very important for localized build. What happen is currently in
modern theme if the selected one is the longest menu item, the text will be
truncated. But in Japanese and Chinese localization, most of the items will be
translated into the same length (2 or 4 chinese/japanese characters). so we will
always only display one chinese (the first one) characters with "..." in it. And
since it only show one characters (it should show two), no body can really tell
what it mean for MOST of the drop down in the pref window or other ui.

please take this for m1.0 and approve it for adt

Comment 31

[Peter Trudelle]

ADT1.0.1+, okay to checkin to the branch once you have drivers' approval.

Comment 32

[Paul Wyskoczka]

Please get drivers approval for this fix.

Comment 33

[Judson Valeski]

please checkin to the 1.0.1 branch. once there remove the "mozilla1.0.1+"
keyword and add the "fixed1.0.1" keyword.

Comment 34

[shliang]

checked into branch a few days ago

Comment 35

[Blake Ross]

An okay workaround for rtm, but this bug is not fixed, just worked around.

Comment 36

[Chris Lyon]

*** Bug 187609 has been marked as a duplicate of this bug. ***

Comment 37

[Frank-Rainer Grahl (:frg)]

I would say this is either long ago fixed or not relevant any longer. I see no bad truncation in long bookmarks. The tooltip provides the long version.

If you think otherwise and have a problem with 2.53.2 or newer please open a new bug with screenshots.