Closed Bug 1350896 Opened 6 years ago Closed 6 years ago

Use Ion GetElem/SetElem ICs in more cases

Categories

(Core :: JavaScript Engine: JIT, defect)

Product:
Core
Component:
JavaScript Engine: JIT
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla55
Tracking Flags:
Tracking Status
firefox55 --- fixed

People

(Reporter: jandem, Assigned: jandem)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Patch
11.94 KB, patch
h4writer
: review+
Details | Diff | Splinter Review
Attached patch Patch — — Splinter Review 
IonBuilder checks a number of conditions that are no longer necessary because the ICs can actually optimize many of these cases now.

 6 files changed, 24 insertions(+), 106 deletions(-)
Attachment #8851586 - Flags: review?(hv1989)
Comment on attachment 8851586 [details] [diff] [review]
Patch

Review of attachment 8851586 [details] [diff] [review]:
-----------------------------------------------------------------

This patch makes me extremely happy.
Attachment #8851586 - Flags: review?(hv1989) → review+
Pushed by jandemooij@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5a479113bc0f
Use Ion GetElem/SetElem ICs in more cases. r=h4writer
https://hg.mozilla.org/mozilla-central/rev/5a479113bc0f
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.