With 'blank screen' selected for New Tab, History and Bookmarks are only accessible from the tab switcher menu

NEW
Unassigned

Status

()

Firefox for iOS
Home screen
P3
normal
8 months ago
8 months ago

People

(Reporter: rnewman, Unassigned)

Tracking

unspecified
All
iOS

Firefox Tracking Flags

(fxios+)

Details

(Whiteboard: [MobileCore][good next bug])

(Reporter)

Description

8 months ago
Can we add the four-item navigation strip to the menu for about:blank, just like any other page?

I think it's disabled because those are expected to be there in 'content', but of course with no content there's no way of getting to those sections at all.

The workaround is to enter the tab switcher and use the menu there, which opens a new tab to the selected panel.
tracking-fxios: ? → +
Priority: -- → P3
Whiteboard: [MobileCore]
(Reporter)

Comment 1

8 months ago
I think this is a relatively easy fix: in AppMenuConfiguration.swift:

    // the items should be added to the array according to desired display order
    fileprivate func menuToolbarItemsForAppState(_ appState: AppState) -> [MenuToolbarItem]? {
        let menuToolbarItems: [MenuToolbarItem]?
        switch appState.ui {
        case .tab, .tabTray:
            menuToolbarItems = [AppMenuConfiguration.TopSitesMenuToolbarItem,
                                AppMenuConfiguration.BookmarksMenuToolbarItem,
                                AppMenuConfiguration.HistoryMenuToolbarItem,
                                AppMenuConfiguration.ReadingListMenuToolbarItem]
        default:
            menuToolbarItems = nil
        }
        return menuToolbarItems
    }


add a case for `.homePanels` and a check for `NewTabAccessors.getNewTabPage(prefs) == .blankPage`. There's precedent for that kind of check in BVC.
Whiteboard: [MobileCore] → [MobileCore][good next bug]

Comment 2

8 months ago
Came here to post about this.  I'm using Firefox Version 7.0 (2330) on an iPhone 6s running iOS 10.3.1

I have my Firefox New Tab Settings set as "Show a Blank Page" and when I have only one blank tab open, if I click the menu button on the bottom I only see New Tab, New Private Tab, Home, and Settings.  I expect to see the full list of options that you see if you were to view the menu from the tab switcher screen, or by viewing a page with content.
You need to log in before you can comment on or make changes to this bug.