1350973 - Implement new attributes MediaStreamAudioSourceNode and MediaElementAudioSourceNode

Status: RESOLVED FIXED

(Core :: Web Audio, enhancement, P3)

Description

[Paul Adenot (:padenot)]

Those new attributes are for convenience: they let you access the HTMLMediaElement and the MediaStream that was passed during the construction of the node.

See https://github.com/WebAudio/web-audio-api/pull/1179, there is still some bike-shedding on the name.

Comment 1

[Bulk Bug Changes for mreavy's org]

Mass change P2->P3 to align with new Mozilla triage process.

Comment 2

[maxime.langlade]

New attributes finally named mediaStearm and mediaElement in the spec. https://github.com/WebAudio/web-audio-api/commit/13e65f9651614034cd6b3e3a7ece36ebe4ccee2b
I'm on the implementation of these attributes on the source code.

Comment 3

[Paul Adenot (:padenot)]

Attachment: Bug 1350973 - Implement new attributes MediaStreamAudioSourceNode.mediaStream and MediaElementAudioSourceNode.mediaElement. r?baku

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e79a64fc49e7
Implement new attributes MediaStreamAudioSourceNode.mediaStream and MediaElementAudioSourceNode.mediaElement. r=baku

Comment 5

[Paul Adenot (:padenot)]

Attachment: Bug 1350973 - Backout because of leaks.

Comment 6

[Stefan Hindli [:stefan_hindli]]

Backed out 3 changesets (Bug 1324552, Bug 1324545, Bug 1350973) for causing perma mda leakcheck failures CLOSED TREE

https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&fromchange=9d4b4711856ae76154757d5fe74b5afe56e25906&selectedJob=255952599

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=255952599&repo=autoland&lineNumber=10258

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b94a7e373671
Implement new attributes MediaStreamAudioSourceNode.mediaStream and MediaElementAudioSourceNode.mediaElement. r=baku

Comment 8

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/b94a7e373671

Comment 9

[Chris Mills [:cmills]]

Docs for these completed; see https://github.com/mdn/sprints/issues/2124#issuecomment-549912801 for the full details.

Let me know if these look OK. Thanks!