Closed Bug 1350981 Opened 8 years ago Closed 8 years ago

Block merging commits when build is consistently failing

Categories

(Firefox for iOS :: Build & Test, enhancement)

Product:
Firefox for iOS
Component:
Build & Test
Platform:
Other
iOS
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: njpark, Unassigned)

Details

We discussed this on last week's ios meeting that when there is a recurring build failure, we should hold off on merging to master until the build is fixed. This is a bug to check off when that's complete. I see that now only 'squash and merge' is enabled, but merge is still allowed even when buddybuild result is red. In focus for android repo for example, the merge button is greyed out until the buddybuild test result is back and it's set to green (I'm assuming that this scheme is also ideal for firefox-ios repo- if not, we can put the reasons here for the record)
No longer depends on: 1350889
I think this bug can be closed, now it is not possible to merge when the build has not finished successfully.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.