1350988 - Baldr: fix async interrupt issues

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, enhancement)

Description

[Luke Wagner [:luke]]

The patch here fixes some intermittent failures we were seeing in tests/asm.js/testBug1117255.js.

Comment 1

[Luke Wagner [:luke]]

Attachment: async-interrupt-pc

This patch gives a separate CodeRange::Type for async interrupt stubs so that the profiling frame iterator can simply skip it since the fp register can hold anything.

Comment 2

[Luke Wagner [:luke]]

Attachment: dont-clobber-in-handler

Comment 3

[Benjamin Bouvier [:bbouvier] (inactive)]

Comment on attachment 8851678 [details] [diff] [review]
async-interrupt-pc

Review of attachment 8851678 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 4

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: fprintf.patch

Just a drive-by patch, that was nice to have for helping debugging.

Comment 5

[Luke Wagner [:luke]]

Comment on attachment 8851689 [details] [diff] [review]
fprintf.patch

Review of attachment 8851689 [details] [diff] [review]:
-----------------------------------------------------------------

Oops, I saw this in your pastebin but thought it was just a temporary debugging printf.  It's a good change, though; I always have to do this myself.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bcb02e41e118
Baldr: don't attempt to unwind when in the interrupt stub (r=bbouvier)
https://hg.mozilla.org/integration/mozilla-inbound/rev/bec48942d615
Baldr: don't clobber scratch register in interrupt stub (r=bbouvier)
https://hg.mozilla.org/integration/mozilla-inbound/rev/6dc3829f182d
Baldr: send ARM simulator dissassembly output to stderr (r=luke)

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/67bfeed62db8
Baldr: disable new test when single-stepping not enabled (r=red)

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/bcb02e41e118
https://hg.mozilla.org/mozilla-central/rev/bec48942d615
https://hg.mozilla.org/mozilla-central/rev/6dc3829f182d
https://hg.mozilla.org/mozilla-central/rev/67bfeed62db8