Reactivate LoginManagerTests

RESOLVED FIXED

Status

()

RESOLVED FIXED
2 years ago
a year ago

People

(Reporter: njpark, Assigned: njpark)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [sec-insecure-third-party-site-reviewed])

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

2 years ago
These tests are disabled and currently not running, the idea is to enable them in UITests and convert part of them to XCUITests and have them enabled, up and running
(Assignee)

Updated

2 years ago
Assignee: nobody → npark
No longer depends on: 1347659
Whiteboard: [sec-insecure-third-party-site-reviewed]
(Assignee)

Comment 1

2 years ago
Created attachment 8853131 [details] [review]
PR Link
(Assignee)

Updated

2 years ago
Attachment #8853131 - Flags: review?(fpatel)
(Assignee)

Comment 2

2 years ago
Created attachment 8855569 [details] [review]
Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/2604
Attachment #8853131 - Attachment is obsolete: true
Attachment #8853131 - Flags: review?(fpatel)
(Assignee)

Comment 3

2 years ago
After Bug 1339824 was fixed, it eliminated the issue where the injected login data was lost after sending the app to background, so I resurrected those tests, as well as adding some example of sending firefox to background in XCUITest.
On top of that, I also upgraded Earlgrey to 1.9.0 and changed syntax.  I also noticed that in some instances the Firefox crashes during UITest- Need to investigate why, and for now the test that caused the crash are disabled.
(Assignee)

Updated

2 years ago
Attachment #8855569 - Flags: review?(fpatel)

Updated

2 years ago
Attachment #8855569 - Flags: review?(fpatel) → review+
(Assignee)

Comment 4

a year ago
Merged:
https://github.com/mozilla-mobile/firefox-ios/commit/6ba2215a564be25941109eca03913af605394258
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.