1351117 - Ensure nsLayoutStylesheetCache uses gUserContentSheetURL correctly, and prevent intermittent asserts on shutdown

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Brad Werth [:bradwerth]]

https://dxr.mozilla.org/mozilla-central/source/layout/style/nsLayoutStylesheetCache.cpp?q=path%3Alayout%2Fstyle%2FnsLayoutStylesheetCache.cpp&redirect_type=single#253 appears to be a non-critical assert, and it's showing up in intermittent oranges on try server builds.

Comment 1

[Brad Werth [:bradwerth]]

Attachment: Bug 1351117 Part 1: Change an assert on nsLayoutStylesheetCache::Shutdown into a warning, since it only notes that the cache was never used.

Review commit: https://reviewboard.mozilla.org/r/145926/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/145926/

Comment 2

[Cameron McCormack (:heycam)]

Comment on attachment 8874581 [details]
Bug 1351117 Part 1: Change an assert on nsLayoutStylesheetCache::Shutdown into a warning, since it only notes that the cache was never used.

https://reviewboard.mozilla.org/r/145926/#review149912

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/98b04000fee7
Part 1: Change an assert on nsLayoutStylesheetCache::Shutdown into a warning, since it only notes that the cache was never used. r=heycam

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/98b04000fee7